?
avatar brianteeman
brianteeman
8 Mar 2020

Sorry my scss-fu is not good enough to fix this - I can do some but not all. @angieradtke can you?

[ ] text color
[ ] border-radius
[ ] border color
[ ] border color : focus
[ ] box-shadow
[ ] box-shadow : focus

before

avatar brianteeman brianteeman - open - 8 Mar 2020
avatar joomla-cms-bot joomla-cms-bot - change - 8 Mar 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 Mar 2020
avatar jwaisner jwaisner - change - 8 Mar 2020
Priority Medium Low
Build staging 4.0-dev
avatar angieradtke
angieradtke - comment - 9 Mar 2020

select tags should like select access?

avatar angieradtke
angieradtke - comment - 9 Mar 2020

.choices.is-focused {border-color:#39f; box-shadow: 0 0 0 .2rem #d3e2f5;}

But.... it looks a little bit strange at the bottom

avatar brianteeman
brianteeman - comment - 9 Mar 2020

I have done most bits except for the part that makes the box-shadow when focused have rounded corners and not square ones - can't find that

avatar jwaisner jwaisner - change - 9 Mar 2020
Priority Low Very low
Status New Confirmed
avatar jwaisner
jwaisner - comment - 9 Mar 2020

Confirmed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28272.

avatar angieradtke
angieradtke - comment - 10 Mar 2020

ah now I understand.
administrator/templates/atum/scss/vendor/choicesjs/choices.scss

`
.choices__inner {
border: $input-border;
border-radius: $border-radius;
box-shadow: $input-box-shadow;
}

.choices.is-focused
{
.choices__inner {
border-color: $focuscolor;
box-shadow: $focusshadow

}
}

`

avatar brianteeman
brianteeman - comment - 10 Mar 2020

thanks - will check it later and submit pr

avatar brianteeman
brianteeman - comment - 10 Mar 2020

did you check that - It doesnt impact on the focus box-shadow corners - they are still square

avatar angieradtke
angieradtke - comment - 10 Mar 2020

border-radius: $border-radius; ???
I have that
brian

avatar brianteeman
brianteeman - comment - 10 Mar 2020

@angieradtke I dont know how you get this to work

It cannot work because $border-radius is not defined in

// Atum Variables
@import "../../variables";
avatar angieradtke
angieradtke - comment - 10 Mar 2020

it's a bootstrap var
media/vendor/bootstrap/scss/_variables.scss

avatar brianteeman
brianteeman - comment - 10 Mar 2020

well your code still doesn't work for me - odd

avatar angieradtke
angieradtke - comment - 10 Mar 2020

hm?

What does the inspector  says? Do you get an error message?

Am 10.03.2020 um 10:30 schrieb Brian Teeman:

well your code still doesn't work for me - odd

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/issues/28272?email_source=notifications&email_token=AAI6HM4FNAGX7EIDNX2X5LDRGYCD7A5CNFSM4LDZNA7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOKU56I#issuecomment-596987641,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI6HMYDHENSFNFYZQ2FCBTRGYCD7ANCNFSM4LDZNA7A.

avatar brianteeman
brianteeman - comment - 10 Mar 2020

can you post an image of your successful inspector please

avatar angieradtke
angieradtke - comment - 10 Mar 2020

sure .-)
brian

avatar brianteeman
brianteeman - comment - 10 Mar 2020

I still get the square corners

avatar infograf768
infograf768 - comment - 11 Mar 2020

Folks. you are not talking about the same thing
@angieradtke
your patch does work by adding a rounded shadow when the choice is limited to one item (select the category when editing an article.)
It does not work when the choices is multiple (searchtools)

avatar angieradtke
angieradtke - comment - 11 Mar 2020

I'm confused
shot1
shot2

avatar angieradtke
angieradtke - comment - 11 Mar 2020

will update my branch

avatar infograf768
infograf768 - comment - 11 Mar 2020

Select condition, select stage, select language etc, do not use fancyselect and choices.

Select category, Select author, Select Tag do (in searchtools), but they are multiple choices fields. Select category when editing an article is a single choice.

shadow

avatar brianteeman
brianteeman - comment - 11 Mar 2020

Based on the class names that @angieradtke mentioned she is talking about the correct place

avatar infograf768
infograf768 - comment - 11 Mar 2020

The problem is not the class name.
What I am trying to explain is that her patch works when fancy select is set to select-one, NOT when fancyselect is set to multiple...
TBH I don't care about such petty issues. There are more important stuff to deal with.

avatar brianteeman
brianteeman - comment - 11 Mar 2020

Sorry you are completely wrong. And if you don't care then don't comment. You don't have to comment on everything

avatar infograf768
infograf768 - comment - 11 Mar 2020

GL

avatar angieradtke
angieradtke - comment - 11 Mar 2020

it's a browser issue.
Firefox has rounded corners, will take a look

avatar angieradtke
angieradtke - comment - 11 Mar 2020

the border-radius has to go to :

.choices { border: 0; border-radius:$border-radius; }

avatar brianteeman brianteeman - change - 27 Mar 2020
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2020-03-27 17:45:59
Closed_By brianteeman
avatar brianteeman brianteeman - close - 27 Mar 2020

Add a Comment

Login with GitHub to post a comment