[#28261] - [4.0] system plugin to add translate no html5 attribute
- Closed
- 10 Oct 2020
- Medium
- Build: 4.0-dev
- # 28261
- Diff
- alikon:patch-107
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28238 .
Summary of Changes
added a system plugin that replace this markup {dontTranslate}Text{/dontTranslate}
with <span translate="no">Text</span>
Testing Instructions
apply pr
discover the plugin
and publish
add the markup {dontTranslate}Text{/dontTranslate} in articles content, article title menu item title ect
Expected result
look at the html of the page
the translate attribute <span translate="no">Text</span>
Actual result
NA
Todo
add the sql
manage better the alias field if the markup is used in the title
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
Please change donttranslate plugin name etc to notranslate. This is imho too much a deteriorated english phrase.
| Labels |
Added:
?
?
|
||
@infograf768 that can be done easily later when the approach got some positive feedback
@SharkyKZ open/close tag done
ready for a round of tests
| Category | Administration Language & Strings Front End Plugins | ⇒ | Administration Language & Strings SQL Installation Front End Plugins |
| Category | Administration Language & Strings Front End Plugins SQL Installation | ⇒ | Administration Language & Strings SQL Installation Postgresql Front End Plugins |
| Category | Administration Language & Strings Front End Plugins SQL Installation Postgresql | ⇒ | SQL Administration com_admin Language & Strings Installation Postgresql Front End Plugins |
Can this at least be disabled by default?
yes, for sure...
Before this is merged it should be decided by production department if it can be accepted as it is not supported by firefox in any version and is still flagged as an experimental feature that may change.
(I implemented this on a site several years ago and it was less than reliable)
you mean this right https://caniuse.com/#search=translate%20attr ?
well the worst that may happen is that text is translated
but it is supported from other tools..
Yes that's the link
Our policy has always been it should work equally across all supported browsers which is why I bring this up
Our policy has always been it should work equally across all supported browsers which is why I bring this up
The "funny" thing is that https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/translate says:
"Although not all browsers recognize this attribute, it is respected by automatic translation systems such as Google Translate, and may also be respected by tools used by human translators. As such it's important that web authors use this attribute to mark content that should not be translated."
The Google translation service for websites has been limited to their product, Chrome. Other browsers are literally locked out. :(
We are talking about browser support for the translate attribute. That's more a philosophical or principal decision in this case, I think.
Before this is merged it should be decided by production department if it can be accepted as it is not supported by firefox in any version and is still flagged as an experimental feature that may change.
(I implemented this on a site several years ago and it was less than reliable)
Mozilla does not support this attribute, because Mozilla does not have a built-in translator, unlike Chrome and other browsers. I think this is logical. But Mozilla recommends adding this attribute to website in his documentation.
| Labels |
Added:
?
|
||
| Category | Administration Language & Strings Front End Plugins SQL Installation Postgresql com_admin | ⇒ | SQL Administration com_admin Postgresql Language & Strings Installation Libraries Front End Plugins |
I have tested this item
Description/Images follow on GitHub
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28261.
New menu item (Site), Single Article:
Front-end view:
Inspector:
Database:
This is the reason I created my theme
There's code in this pr to avoid that. Means: Anybody is and was aware of the problem. Now we have to solve it or close the pr if not solveable.
TBH: From my point of view it's the job of the user to check and correct the alias. Everything else is luxury ;-)
i've added some improvements,
another round of tests please
Looks like working now using unicode slugs or not.
{dontTranslate}Coca Cola{/dontTranslate} ànewarticle
will give as alias with unicodeslugs
coca-cola-ànewarticle
without unicodeslugs
coca-cola-anewarticle
I have tested this item
I have tested the plugin at different places: Menu Item titles, Texts in different components, in module titles and all worked as expected. Tested with mySQLi only.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28261.
thanks folks for testing and commenting---- still more to do , i believe
as it is a big change, please be patient
but togheter we can do it
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-10 09:27:35 |
| Closed_By | ⇒ | alikon | |
| Labels |
Added:
Conflicting Files
|
||
Please change the syntax to use opening/closing tags, e.g.
{notranslate}Text{/notranslate}. This should avoid issues like #21329.