Feeling Lucky
?
?
?
[#28242] - [4.0] Remove 'legacy' checks from content->icons layouts
- Fixed in Code Base
- 9 Mar 2020
- Medium
- Build: 4.0-dev
- # 28242
- Diff
- ciar4n:com-content-edit-icon-legacy
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
I presume the legacy checks in the content->icons layouts are no longer required? This PR removes them.
Testing Instructions
Code review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
chmst
- comment
- 6 Mar 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28242.
alikon
- comment
- 6 Mar 2020
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28242.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 6 Mar 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28242.
brianteeman
- comment
- 6 Mar 2020
Was this marked as deprecated in J3? Should it have been?
ciar4n
- comment
- 6 Mar 2020
Was this marked as deprecated in J3?
It doesn't appear to have been.
wilsonge
- comment
- 9 Mar 2020
It can/should be - but I think it's going to provide less value than normal as it's not going to show in typehints etc.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-09 11:33:39 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 9 Mar 2020
merging - let's get a deprecation notice in 3.x
Thx @SharkyKZ @chmst
Indentation removed. HTMLHelper removed from create.php