[#28240] - [4.0] Change background from span to btn
- Closed
- 6 Mar 2020
- Low
- Build: 4.0-dev
- # 28240
- Diff
- astridx:gap
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
In Firefox under Ubuntu I see a small gap in the upper area in the dropdowns. At least with Firefox on Ubuntu. You have to look very closely. My change corrects this.
Testing Instructions
- Create an article and look at the button to open the actions. You can see a small gap in the upper area.
- Apply this patch
- run
npm ci - See, that there is no small gap in the upper area anymore.
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
richard67
- | Title |
|
||||||
@brianteeman The button still has rounded corners on the right where it touches the green part
I don't understand what you mean.
I do not see round corners with Firefox on Ubuntu. It is like in my pictures.
How does it look for you without my change?
The same
But you see the small gap between the green and the upper boarder without the patch, right?
Yes. Before and after. But I also see my issue in your screenshot
On your screen I can not see the gap.
I mean this:
Yes I understand but can't you also see the issue on the left in that image
On Thu, 5 Mar 2020, 21:22 Astrid, notifications@github.com wrote:
On you screen I can not see the gap.
I mean this:
[image: 2020-03-05 22 19 02]
https://user-images.githubusercontent.com/9974686/76026627-7177ce00-5f2f-11ea-86f2-d77752f0e44e.png—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/28240?email_source=notifications&email_token=AAJ4P4N5DFEG6K4Y5D2T4OLRGAJ2XA5CNFSM4LCN6PF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN66SIA#issuecomment-595454240,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ4P4IMLEQ6FEXWAP2QPYDRGAJ2XANCNFSM4LCN6PFQ
.
The change does exactly what is said, it removes the gap on the green dropdown button.
The rounded boder is another scope.
Is it a button? If yes, it must have rounded border as all buttons and must be clearly separated from the input field. At the moment it looks awkward as @brianteeman says.
Is it part of the button group like in boostrap append / prepend and as @infograf768 has made with css for rtl? Then is must be made with append / prepend, which means: remove all the css stuff which meanwhile has been added in different overrides and use bootstrap correctly.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28240.
jwaisner
- | Priority | Medium | ⇒ | Low |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-06 21:28:47 |
| Closed_By | ⇒ | astridx |
The button still has rounded corners on the right where it touches the green part