[#28221] - [4.0] Fixing Module xtd filters
- Closed
- 6 Mar 2020
- Medium
- Build: 4.0-dev
- # 28221
- Diff
- infograf768:4.0_module_xtd
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28221.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28221.
This isn’t the correct fix. First I’m unsure whether all modals are always displaying site modules. If this is the case then make the change here
https://github.com/infograf768/joomla-cms/blob/eba21d47cce29c2f6d1bab6d8ee23e3569851494/administrator/components/com_modules/src/Model/ModulesModel.php#L110 Removing the client site check from the if statement
I can't find another use of this modal.
the code you point to should work as it is a IF OR
// Special case for the client id.
if ($app->isClient('site') || $layout === 'modal')
{
$this->setState('client_id', 0);
$clientId = 0;
}
but it does not... thus why I used this solution.
Folks, if I trust my last tests here, this is no more an issue.
Could someone confirm?
confirmed
ah that makes sense
This is not working anymore. Closing
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-06 09:30:29 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on eba21d4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28221.