?
avatar C-Lodder
C-Lodder
3 Mar 2020

Steps to reproduce the issue

  1. Go to any table view
  2. Hover over one of the table headings

You've notice the link becomes underlined, however there is a blank space at the end that also contains the underline.

screeny

Use a margin to push the icon away from the text, not a space.

avatar C-Lodder C-Lodder - open - 3 Mar 2020
avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Mar 2020
avatar C-Lodder C-Lodder - change - 3 Mar 2020
The description was changed
avatar C-Lodder C-Lodder - edited - 3 Mar 2020
avatar brianteeman
brianteeman - comment - 4 Mar 2020

image

There is no space there.
Margin does the same - its because of the markup and I am not sure of a css way to resolve it

avatar jwaisner jwaisner - change - 4 Mar 2020
Priority Medium Very low
Status New Confirmed
Build staging 4.0-dev
avatar C-Lodder
C-Lodder - comment - 4 Mar 2020

There's a space in the layout, between the <span> elements:

	<?php if (!empty($data->title)) : ?>
		<span>
			<?php echo Text::_($data->title); ?>
		</span><!-- Span ends here -->
[xxxx]<?php endif; ?>
[xxxx]<span class="<?php echo $icon; ?>" aria-hidden="true"></span>
^^^
whitespace

If you make it all one line:

<?php if (!empty($data->title)) : ?><span><?php echo Text::_($data->title); ?></span><?php endif; ?><span class="ml-1 <?php echo $icon; ?>" aria-hidden="true"></span>

Then it fixes the issue, but will probably fail drone CS tests.

Maybe there's a some PHP magic that can be done

avatar brianteeman
brianteeman - comment - 4 Mar 2020

i will take a look - we have had this issue before with cs breaking stuff

avatar C-Lodder C-Lodder - change - 4 Mar 2020
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2020-03-04 15:13:44
Closed_By C-Lodder
avatar C-Lodder
C-Lodder - comment - 4 Mar 2020

PR: #28225

avatar C-Lodder C-Lodder - close - 4 Mar 2020

Add a Comment

Login with GitHub to post a comment