Namespaces the JAdapter classes for 3.10-dev (which will then be ported to 3.10-dev)

@wilsonge Is there maybe some typo in the description? The PR is for the 3.10-dev, and you want to port it to 3.10-dev, too? That doesn't make sense.

Yup. Fixed :)

Why did you namespace it? It is deprecated.

It's deprecated for 5.x - we're still using it through 4.x for the Installer classes. And I want the last of the non-namespaced classes in the libraries/joomla folder in the 4.x branch to get namespaced.

It's better to remove it from the installer classes and then leave it, same as we did with the "New MVC". I guess we even discussed that long time ago, to keep it not namespaced ?

That would involve another large refactor of the installer classes. It's not happening - we're keeping this one until J5. Choose the right fights :) New MVC removal is going to be decided by Production in their next meeting ;)

Sorry for being a bit late to the party, but shouldn't the 2 files libraries/joomla/base/adapter.php and libraries/joomla/base/adapterinstance.php and also the folder libraries/joomla/base which will be empty without these 2 files be deleted on update, i.e. added to the files and folder deletion in script.php in 3.10?

I just see the files have been later added to script.php with this commit: 7466dab .

And again later they were added to the list of folders to be removed with this commit: 3200667 . And here is the mistake: It should not be the files but only the folder which has been added there.

Will make PR in a few minutes.

See #33868 .