[#28173] - [4.0] Remove the min attribute from the com csp csp values xml
- Fixed in Code Base
- 3 Mar 2020
- Medium
- Build: 4.0-dev
- # 28173
- Diff
- zero-24:csp_remove_min
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue partial #28171
Summary of Changes
Remove the min attribute from the com csp csp values xml
Testing Instructions
Go to System > Manage > Content Security Policy > Options
set the CSP Mode to custom
add directive below
add 2nd directive
try delete all directives...
Expected result
all directives are deleted
Actual result
Actual result: I can delete all, until one directive (first) still remain. I can't delete it.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_csp |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28173.
| Status | Pending | ⇒ | Ready to Commit |
To me it seems it solves the issue completely.
Well as said there I personally would expect that the last delete would reset the values to empty, this here just masks the issue.
I does not need to be re-opend when it is just me having that expectation :)
@richard67: To me it seems it solves the issue completely.
@zero-24: Well as said there I personally would expect that the last delete would reset the values to empty, this here just masks the issue.
@richard67: @zero-24 Thanks for explanation. Do you recommend to re-open the original issue #28171 ?
@zero-24: I does not need to be re-opend when it is just me having that expectation :)
What does @blueforce as the author of the issue think?
Yes works as expected... It's more consistent and the same behavior (UX) as the other filter options
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28173.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-03 12:24:04 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on d53c09e
1. I opened System > Manage > Content Security Policy > Options
2. I set set the CSP Mode to custom
3. I added two smple directive
Before applying this patch I could not delete the last directive. After it was possible.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28173.