? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
29 Feb 2020

Pull Request for Issue #28048 (comment)

Summary of Changes

Creating rtl bootstrap overrides in template-rtl.scss

Testing Instructions

Install Persian language.
Select Persian for back-end.
Display Articles Manager

Before patch

Screen Shot 2020-02-29 at 18 56 11

After patch

Screen Shot 2020-02-29 at 18 54 56

Documentation Changes Required

avatar infograf768 infograf768 - open - 29 Feb 2020
avatar infograf768 infograf768 - change - 29 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Feb 2020
Category Administration Templates (admin)
avatar SharkyKZ
SharkyKZ - comment - 29 Feb 2020

Thanks, but please use mixins instead of hardcoded properties/values.

avatar infograf768
infograf768 - comment - 1 Mar 2020

Do you mean using for example

+  border-top-left-radius: $border-radius;
+  border-bottom-left-radius: $border-radius;
+  border-top-right-radius: 0;
+  border-bottom-right-radius: 0;

as $border-radius is defined in variables ?

avatar SharkyKZ
SharkyKZ - comment - 1 Mar 2020

There is a function for this. This should work:

@include border-left-radius($border-radius);
@include border-right-radius(0);
avatar infograf768 infograf768 - change - 1 Mar 2020
Labels Added: ?
avatar infograf768
infograf768 - comment - 1 Mar 2020

It works. PR modified. Please test.

avatar Quy
Quy - comment - 1 Mar 2020

I have tested this item successfully on 69f931a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28161.

avatar Quy Quy - test_item - 1 Mar 2020 - Tested successfully
avatar astridx
astridx - comment - 1 Mar 2020

I have tested this item successfully on 69f931a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28161.

avatar astridx astridx - test_item - 1 Mar 2020 - Tested successfully
avatar astridx
astridx - comment - 1 Mar 2020

I tested successful.
Before and after
مدیریت مطلب  مطالب   test   مدیریت
مدیریت مطلب  مطالب   test   مدیریت(1)

avatar astridx astridx - change - 1 Mar 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 1 Mar 2020

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28161.

avatar wilsonge wilsonge - change - 2 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-02 13:28:48
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 2 Mar 2020

Thanks!

Add a Comment

Login with GitHub to post a comment