? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
29 Feb 2020

Summary of Changes

Correcting home menu items badges by rounding them and star display.

Testing Instructions

Install a multilingual site.
Display the sidebar menu.
Display the Menus Dashboard
Open com_associations, and look at the language badges

Before patch

com_associations

Screen Shot 2020-02-27 at 11 04 52_before

Sidebar menu

Screen Shot 2020-02-29 at 08 34 13

Menus Dashboard

Screen Shot 2020-02-29 at 08 35 33

After patch

com_associations

Screen Shot 2020-02-27 at 11 04 23

Sidebar menu

home after

Menus Dashboard
Screen Shot 2020-02-29 at 08 40 31

avatar infograf768 infograf768 - open - 29 Feb 2020
avatar infograf768 infograf768 - change - 29 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Feb 2020
Category Administration Templates (admin)
avatar Fedik
Fedik - comment - 29 Feb 2020

I have tested this item successfully on 730815b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28131.

avatar Fedik Fedik - test_item - 29 Feb 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 29 Feb 2020

I have tested this item successfully on 730815b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28131.

avatar brianteeman brianteeman - test_item - 29 Feb 2020 - Tested successfully
avatar infograf768 infograf768 - change - 29 Feb 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 29 Feb 2020

rtc Thanks for testing


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28131.

avatar richard67
richard67 - comment - 29 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28131.

avatar richard67 richard67 - change - 29 Feb 2020
Labels Added: ? ?
avatar astridx
astridx - comment - 29 Feb 2020

I tested that. I don't like important. I don't think we need that here, do we?

For me the star looked OK with


  .home-image {
    padding: .8rem 0;
  }

avatar infograf768
infograf768 - comment - 29 Feb 2020

@astridx
!important is needed. Otherwise this takes over

with

.main-nav span.fas {
    padding: .9rem 0;
}

without !important we do not get the star aligned correctly

Screen Shot 2020-02-29 at 11 41 26

with important, we get

Screen Shot 2020-02-29 at 11 42 33

avatar infograf768
infograf768 - comment - 29 Feb 2020

In fact what misses here is a small change for quickstart + icon

.main-nav li .menu-dashboard > a > .fas, .main-nav li .menu-quicktask > a > .fas {
    display: flex;
    align-items: center;
    padding: .9rem;    /////instead of 1rem
    margin: 0;
}

Screen Shot 2020-02-29 at 11 50 40

can do here or in another pr.

avatar astridx
astridx - comment - 29 Feb 2020

Thanks for explaining. I actually only looked at the second (horizontal) value . But I would also use no important for overwriting the the first one (vertical). I would do this:

home-image {
   padding: 0;
   &.fa-star {
   	padding: .8rem 0;
   }
 }

That only applies to the star, or am I missing something

avatar ciar4n
ciar4n - comment - 29 Feb 2020

Has hound stopped working again?

avatar blueforce
blueforce - comment - 29 Feb 2020

I have tested this item successfully on 730815b

Tested with:
Chrome 80.0.3987.122
PHP 7.3.14


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28131.

avatar blueforce blueforce - test_item - 29 Feb 2020 - Tested successfully
avatar infograf768 infograf768 - change - 29 Feb 2020
Labels
avatar infograf768
infograf768 - comment - 29 Feb 2020

@astridx
Corrected as suggested + also corrected aligment for dashboard and plus icons

Folks, please test again.

avatar astridx
astridx - comment - 1 Mar 2020

I tested this again.

  1. git fetch origin pull/28131/head:4.0_batch_menuitems_star
  2. git checkout 4.0_batch_menuitems_star
  3. npm ci
    Everything is fine with the star. Thank you @infograf768 . I see no difference with the plus icon, it so little. But the code is uses.

Before and after
Menu Dashboard   test   Administration(1)

--

Menu Dashboard   test   Administration(2)

--

Screenshot from 2020 03 01 12 58 00(1)

avatar astridx
astridx - comment - 1 Mar 2020

I have tested this item successfully on 2b3f8eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28131.

avatar astridx
astridx - comment - 1 Mar 2020

I have tested this item successfully on 2b3f8eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28131.

avatar astridx astridx - test_item - 1 Mar 2020 - Tested successfully
avatar astridx
astridx - comment - 1 Mar 2020

I have tested this item successfully on 2b3f8eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28131.

avatar astridx astridx - test_item - 1 Mar 2020 - Tested successfully
avatar astridx astridx - test_item - 1 Mar 2020 - Tested successfully
avatar HLeithner HLeithner - change - 1 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-01 18:59:08
Closed_By HLeithner
avatar HLeithner HLeithner - close - 1 Mar 2020
avatar HLeithner HLeithner - merge - 1 Mar 2020
avatar HLeithner
HLeithner - comment - 1 Mar 2020

Thanks

Add a Comment

Login with GitHub to post a comment