Feeling Lucky
?
[#28117] - [4.0][com_joomlaupdate] - fix notice on php 7.4
- Closed
- 27 Feb 2020
- Medium
- Build: 4.0-dev
- # 28117
- Diff
- alikon:patch-107
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28111 (1).
Summary of Changes
php 7.4 fix notice
Testing Instructions
visit url administrator/index.php?option=com_joomlaupdate with php 7.4
you'll get Notice: Trying to access array offset on value of type bool in administrator\components\com_joomlaupdate\src\View\Joomlaupdate\HtmlView.php on line 143
on php 7.3
$this->ftp['enabled'] is null
but
$ftp['enabled'] is false
code review
Expected result
no notice
Actual result
Notice
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
| Labels |
Added:
?
|
||
alikon
- comment
- 27 Feb 2020
SharkyKZ
- comment
- 27 Feb 2020
Because your fix is wrong. It should be the other way around. $this->ftp is also used in the layouts.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-27 20:50:45 |
| Closed_By | ⇒ | alikon |
alikon
- comment
- 27 Feb 2020
quite confused so let me close it
This is already fixed in staging.