[#28115] - Update Appveyor to test against PHP 7.4
- Fixed in Code Base
- 28 Mar 2020
- Medium
- Build: staging
- # 28115
- Diff
- joomla:appveyor-php74
- Pending continuous-integration/drone/push Build is running Details
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
- Pending continuous-integration/travis-ci/push The Travis CI build is in progress Details
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Updates the SQLSrv extension to 5.8.0 which also supports PHP 7.4 https://pecl.php.net/package/sqlsrv/5.8.0
See appveyor tests pass on new version to test
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
If I had to guess, something to do with the deprecated $context parameter of the callable for error handlers being a null value, and PHPUnit 4.8 not being any kind of PHP 7 compatible expects it to always be an array as was the case before it was deprecated in PHP 7.2. So, you're probably going to need some handling in that Closure to deal with that.
I saw the context parameter had gone in the later versions of symfony and was afraid you were going to say that
| Labels |
Added:
?
?
|
||
Merging for now so the tests run - as i believe they are the same failures on appveyor and they can be enabled then in the same set of commits
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-28 18:59:38 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Removed: ? |
||
@mbabker at a quick glance can you see why https://github.com/joomla/joomla-cms/blame/staging/tests/unit/core/helper.php#L55 is failing so hard in Appveyor PHP 7.4 - seems to be the same thing making travis fail - so don't think it's environment specific