?
avatar brianteeman
brianteeman
27 Feb 2020

I suspect these are php 7.4 specific issues but don't currently have anything lower to test on

url administrator/index.php?option=com_joomlaupdate

1 - all pages

Notice: Trying to access array offset on value of type bool in administrator\components\com_joomlaupdate\src\View\Joomlaupdate\HtmlView.php on line 143

2 - Upload and Update tab

Notice: Undefined variable: message in administrator\components\com_joomlaupdate\tmpl\joomlaupdate\default_upload.php on line 36

Notice: Trying to access array offset on value of type null in administrator\components\com_joomlaupdate\tmpl\joomlaupdate\default_upload.php on line 36

avatar brianteeman brianteeman - open - 27 Feb 2020
avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 27 Feb 2020
avatar SharkyKZ
SharkyKZ - comment - 27 Feb 2020

First one already fixed in staging #27219. See PR #28112 for the other one.

avatar alikon
alikon - comment - 27 Feb 2020

lookin only at code for 1)
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_joomlaupdate/src/View/Joomlaupdate/HtmlView.php#L143

should be

$this->ftpFieldsDisplay = $ftp['enabled'] ? '' : 'style = "display: none"';

but unable to test now

avatar wilsonge
wilsonge - comment - 27 Feb 2020

Closing this. I know the second one isn't fixed in 4.0-dev but I'm going to sit down a do a set of merging up which will de facto shut this other part. @alikon is right in terms of the fix thats going to come

avatar wilsonge wilsonge - change - 27 Feb 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-02-27 13:08:41
Closed_By wilsonge
avatar wilsonge wilsonge - close - 27 Feb 2020
avatar alikon
alikon - comment - 27 Feb 2020

Add a Comment

Login with GitHub to post a comment