? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
27 Feb 2020

Pull Request for Issue #28100.

Summary of Changes

This moves eslint from hound to drone CI, thus using the eslint from our package.json.

avatar Hackwar Hackwar - open - 27 Feb 2020
avatar Hackwar Hackwar - change - 27 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2020
Category Unit Tests
avatar Hackwar Hackwar - change - 27 Feb 2020
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 27 Feb 2020

I'm tempted to stick with hound. Only because it comments with suggestions for how to fix - which to me feels like it's going to be easier for new contributors or those with less technical experience?

avatar Hackwar Hackwar - change - 27 Feb 2020
Labels Added: ?
Removed: ?
avatar dgrammatiko
dgrammatiko - comment - 27 Feb 2020

I'm tempted to stick with hound

Please reconsider. Hound was a service that fulfilled something that wasn't possible couple of years ago in GitHub. Nowadays we have actions, so a simple script can take all the artefacts from each PR (PHPCS. ESLINT, SCSS LINT. etc) and expose them in the PR as a comment or comments. So whatever Hound is doing is totally within the reach of plain GitHub Actions and without having to sync different services (it's a mess). Eg since this was kicked for ESlint: https://github.com/marketplace/actions/eslint-action

PS. Not to mention that you can offload all the drone work to Github action and reduce the bills...

avatar brianteeman
brianteeman - comment - 28 Feb 2020

I agree with @wilsonge about the way that hound comments being a good thing. also drone fails so often its not a useful tool at all

avatar dgrammatiko
dgrammatiko - comment - 28 Feb 2020

It won’t be drone but Github actions if for once you hear what I’m saying...

avatar brianteeman
brianteeman - comment - 28 Feb 2020

If you read more carefully you would have realised I meant the way that drone comments is good. I dont care what tool is used as long as it actually works. (drone doesnt)

avatar wilsonge
wilsonge - comment - 28 Feb 2020

Ok Eslint GitHub actions seems viable from a quick glance in terms of the comments it gives. However wouldn’t we then have to maintain + support it?

avatar dgrammatiko
dgrammatiko - comment - 28 Feb 2020

However wouldn’t we then have to maintain + support it?

Let's be realistic here, right now you admin and maintain (and also pay) for drone and travis. Moving these tasks to GH Actions will remove the administrative work (server pampering) but of course will not eliminate casual maintenance, it's still executable code (although yml) so same rules apply. What you'll remove from the equation are the own servers, which should be beneficial long term (less people doing plumping instead of contributing actual code for the product, etc).
FWIW I think it will be better if the production team sets some goals for moving to GH actions and start moving small chunks. Eg all the js related parts: lint, tests etc can be moved out of DRONE right now.
The only part that needs some consideration and probably figure out the optimal solution is that the actions, if implemented right now, will target the branch 4.0-dev but once you'll switch to staging there will be a need for some adjustments. Also unfortunately you can't play with the actions in your local env right now so also another negative...

PS: you as the project

avatar dgrammatiko
dgrammatiko - comment - 28 Feb 2020

@wilsonge @Hackwar it might worth the time investigating moving

Such implementation will leave only the tests on the DRONE machine so, theoretically, should be faster to get the results for the codestyle errors

avatar C-Lodder
C-Lodder - comment - 29 Feb 2020

@wilsonge I use GH Actions on some of my own personal projects. You simply tell it to install NodeJS, run npm i and then whatever tasks you wish to run. There is no maintenance required and it's much better keeping things in-house when possible. It took 2 minutes to setup when testing the WebAuth PR

avatar wilsonge
wilsonge - comment - 12 Mar 2020

Closing this. As is it isn't the correct tool. At minimum to move to drone you need to add the ability to annotate PRs into this. But would be more than happy to see some work moving to actions if we wanted to go that way too

avatar wilsonge wilsonge - change - 12 Mar 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-03-12 13:53:13
Closed_By wilsonge
Labels Added: ?
Removed: ?
avatar wilsonge wilsonge - close - 12 Mar 2020

Add a Comment

Login with GitHub to post a comment