[#28079] - [4.0][Atum] Redundant CSS - '.login-logo'
- Fixed in Code Base
- 25 Feb 2020
- Medium
- Build: 4.0-dev
- # 28079
- Diff
- ciar4n:login-logo
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This appears to be redundant CSS. No sign of such a class in the login markup.
Testing Instructions
Apply this patch and run node build.js --compile-css for updating the changed SCSS. Check login page displays correctly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28079.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28079.
RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28079.
| Labels |
Added:
?
|
||
@ciar4n It seems there went something wrong when I resolved the conflict. I am sure I did it right, removed the code to be removed with this PR and not added back the code removed with the previously merged #28078, but the result looks wrong, GitHub has added back the code which had been removed with #28078 . Can it bee that I just was too fast?
Update: Solved.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-25 18:44:53 |
| Closed_By | ⇒ | richard67 |
Thanks.
I have tested this item✅ successfully on 77703d4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28079.