[#28077] - Only collect contacts when requested
- Fixed in Code Base
- 29 Feb 2020
- Medium
- Build: staging
- # 28077
- Diff
- zero-24:massive_contacts
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28074
Summary of Changes
Only collect contacts when requested to avoid looking over all contacts
Testing Instructions
- create more than one contact
- create a single contact menu item
- open the item
- apply this patch
- see the page again
- enable the option "show_contact_list"
- make sure that still works
Expected result
everything works than expected and no more longstanding 90% of the time useless loop over all contacts.
Actual result
A long standing loop over all contacts even on the single contact page.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28077.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28077.
richard67
- | Status | Ready to Commit | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28077.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28077.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28077.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-29 08:29:33 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Could this also apply to assets?
What happens for example in a news page that has accumulated thousands of articles?
What happens for example in a news page that has accumulated thousands of articles?
Feel free to try and open an issue with the result so we can work on a patch when there is a problem. This here was specifically about that contact issue.
I have tested this item✅ successfully on 9ccd259
Tested with setting "Show Contact List" in global "Contacts" configuration/options and debug line in view.html.php.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28077.