? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
25 Feb 2020

Summary of Changes

Adds JFormFilterInt_Array alias proxied to Joomla\CMS\Form\Filter\IntarrayFilter so forms using INT_ARRAY filter continue to be filtered properly.

Testing Instructions

Create Articles - Category module.
In Filtering Options select some categories.
Save the module.
Go to your database and find the module in #__modules table.
In params column inspect catid value.

Expected result

Values are stored as integers: "catid":[8,9]

Actual result

Values are stored as strings "catid":["8","9"]

Documentation Changes Required

IDK.

avatar SharkyKZ SharkyKZ - open - 25 Feb 2020
avatar SharkyKZ SharkyKZ - change - 25 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2020
Category Libraries
avatar SharkyKZ SharkyKZ - change - 25 Feb 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 25 Feb 2020
avatar joomdonation
joomdonation - comment - 26 Feb 2020

I have tested this item successfully on a43dab8

Works as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28072.

avatar joomdonation joomdonation - test_item - 26 Feb 2020 - Tested successfully
avatar joomdonation
joomdonation - comment - 26 Feb 2020

Question: Currently, we have many filter="int_array" in parameters. Maybe you can help updating it to the new filter to Intarray to prevent the deprecated trigger?

avatar SharkyKZ
SharkyKZ - comment - 26 Feb 2020

I'll make a separate PR for that. This should be tested first.

avatar Quy
Quy - comment - 27 Feb 2020

I have tested this item successfully on a43dab8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28072.

avatar Quy Quy - test_item - 27 Feb 2020 - Tested successfully
avatar Quy Quy - change - 27 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 27 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28072.

avatar rdeutz rdeutz - change - 28 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-28 08:17:23
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 28 Feb 2020
avatar rdeutz rdeutz - merge - 28 Feb 2020

Add a Comment

Login with GitHub to post a comment