Joomla! Issue Tracker | Joomla! CMS #2807 - Use alternative CURL when allow_url

Closed
9 Jun 2014
Medium
Build: staging
# 2807
Diff
jms2win:patch-8

Success

Success The Travis CI build passed Details

User tests: Successful: Unsuccessful:

jms2win
17 Jan 2014

We propose to add an alternative method to get the feed when the allow_url_open is OFF.
When the allow_url_open is OFF, the XMLReader::open always fails because the URL can not be connected.

So we propose to get the Feed with the alternative CURL when it is present.

e6e4bcb 17 Jan 2014

Use alternative CURL when allow_url_open is OFF

jms2win - open - 17 Jan 2014

zero-24 - comment - 17 Jan 2014

Hi jms2win
thanks for your contribution.
here is your Tracker:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33163&start=0

mbabker - comment - 17 Jan 2014

I'd actually suggest using JHttp instead of hard coding cURL in here as our JHttp library supports cURL, socket, and stream connections. Otherwise, this is a good idea IMO.

$connector = JHttpFactory::getHttp();

try {
    $feed = $connector->get($uri);
} catch (RuntimeException $e) {
    // This is typically a failed connection
} catch (UnexpectedValueException $e) {
    // The connector failed to correctly read the HTTP headers
}

ce142e4 28 Jan 2014

New proposal to use CURL when the allow_url_open is OFF

jms2win - comment - 28 Jan 2014

I have updated the proposal to the the suggested JHttpFactory::getHttp();

You will see that I didn't put any Try/Catch as the function as to throw exception in case of errors.
So I have kept the JHttpFactory exceptions throw to the caller.