[#28064] - [4.0] template-rtl codestyle
- Closed
- 25 Feb 2020
- Medium
- Build: 4.0-dev
- # 28064
- Diff
- brianteeman:new_beginnings6
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
The scc-lint is not running :(
This PR fixes as many issues as I can according to our codestyle rules found in scss-lint.yml
Code review and check scss compiles
Feel free to fix other files
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
these changes were made by running the linter locally and then following the reports
Oh Hound. Hmm I'll try and look into this
Thanks - I would really appreciate it as my local lint report is humungous
@brianteeman ROOT/scss-lint.yml
Replace:
scss_files:
"administrator/components/com_media/resources/**/*.scss"
"administrator/templates/**/*.scss"
"build/media_source/**/*.scss"
"templates/**/*.scss"
with:
scss_files: [
"administrator/components/com_media/resources/**/*.scss",
"administrator/templates/**/*.scss",
"build/media_source/**/*.scss",
"templates/**/*.scss"
]
You'll probably want to undo all your changes in this PR though as they go against the linter rules :)
The linter wasn't actualy working at all. It threw an error due to an invalid YML file on my fork but doesn't appear to do so on here for some reason.
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-25 12:10:00 |
| Closed_By | ⇒ | brianteeman |
How are you trying to run the linter?