? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
24 Feb 2020

Pull Request for Issue #28050 .

Summary of Changes

Arrow in dropdown is not visible during installation.
Replace light arrow with dark arrow svg files.

Testing Instructions

Apply PR.
Delete configuration.php.
Do new install.
See visible arrow in dropdown.

avatar Quy Quy - open - 24 Feb 2020
avatar Quy Quy - change - 24 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2020
Category Installation
avatar jwaisner
jwaisner - comment - 24 Feb 2020

I have tested this item successfully on 9b64f45


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28059.

avatar jwaisner jwaisner - test_item - 24 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 24 Feb 2020

These files were copied from /administrator/templates/atum/images/.

With your suggestion, there is no arrow.
arrow-svg

avatar C-Lodder
C-Lodder - comment - 24 Feb 2020

@Quy Try setting the width/height too.

avatar Quy
Quy - comment - 24 Feb 2020

I did the width/height, but no go. Please provide the exact code to use. Thanks.

avatar infograf768
infograf768 - comment - 25 Feb 2020

Replacing both svg (rtl and ltr) in installation with the ones from Atum works perfectly.

I see no reason to create different svg. + if in the future, for any reason we need to modify these again, it will be simpler.

Screen Shot 2020-02-25 at 08 20 42

Screen Shot 2020-02-25 at 08 21 33

avatar infograf768
infograf768 - comment - 25 Feb 2020

I have tested this item successfully on 9b64f45


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28059.

avatar infograf768 infograf768 - test_item - 25 Feb 2020 - Tested successfully
avatar infograf768 infograf768 - change - 25 Feb 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 25 Feb 2020

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28059.

avatar infograf768 infograf768 - change - 25 Feb 2020
Title
[4.0] Fix arrow to be visible in dropdown
[4.0] Installation: Fix arrow to be visible in dropdown
avatar infograf768 infograf768 - edited - 25 Feb 2020
avatar richard67
richard67 - comment - 25 Feb 2020

Replacing both svg (rtl and ltr) in installation with the ones from Atum works perfectly.

I see no reason to create different svg. + if in the future, for any reason we need to modify these again, it will be simpler.

Agree.

avatar richard67
richard67 - comment - 25 Feb 2020

Merging as it is an improvement to the current state.

@C-Lodder Feel free to make a PR to improve the SVGs further if necessary/useful.

avatar richard67 richard67 - change - 25 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-25 19:25:06
Closed_By richard67
Labels Added: ? ?
avatar richard67 richard67 - close - 25 Feb 2020
avatar richard67 richard67 - merge - 25 Feb 2020
avatar richard67
richard67 - comment - 25 Feb 2020

Thanks.

Add a Comment

Login with GitHub to post a comment