[#28038] - [4.0] logo path not polyline
- Fixed in Code Base
- 24 Feb 2020
- Medium
- Build: 4.0-dev
- # 28038
- Diff
- brianteeman:logo
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
The svg logo contained a mix of path and polyline. this PR changes it so that they are all paths
after
For reference the command to convert the polylines was
svgo --pretty --config='{"full":true}' --enable=convertShapeToPath filename.svg
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
How is it misleading to have a file called logo blue where the only color is blue
the background should not be blue. Test what happens if you change the hue of the template in the template-parameter. I thought we can make the color of svg path and polyline configurable using the template vars
- the logo should not have had a mix of path and polyline - that was a mistake - i fixed it which is all this PR does
- the logo is a single colour - it doesnt matter what colour it is
- there is no background
ah cool brian , sorry I missunderstood
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28038.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28038.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28038.
I have tested this Patch successful.
git fetch origin pull/28038/head:logo
git checkout logo
No new install or npm ci is needed.
I tested with the current 4.0.0-beta1-dev on Ubuntu with PHP 7.2 and MySQL 5.7.
Before:
After
| Labels |
Added:
?
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-24 07:14:53 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
Thanks
thank you Robert
now the file-name is misleading