? ? Pending

User tests: Successful: Unsuccessful:

avatar twister65
twister65
23 Feb 2020

Pull Request for Issue #27945 .

Summary of Changes

Provides the FTP configuration details, depending on the installation method.
Fix the FTP connection.

Testing Instructions

  • System -> Global Configuration -> Server -> Enable FTP -> Yes

  • Save & Close

  • System -> Update - Joomla -> Upload & Update

  • Installation method -> Write files directly

It hides all FTP fields.

  • Installation method -> Write files using FTP

or -> Hybrid (use FTP only if needed)

Expected result

It displays the FTP fields (host, port, username, password, root).

Actual result

It hides the FTP fields (host, port, username, password, root).

Additional comment

You can push the test to the end by clicking on the "Upload & update" button, but you will need an update package containing these modifications, and of course an ftp configuration corresponding to your test server.

avatar twister65 twister65 - open - 23 Feb 2020
avatar twister65 twister65 - change - 23 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2020
Category Administration com_config com_joomlaupdate JavaScript Repository NPM Change
avatar twister65
twister65 - comment - 23 Feb 2020

@richard67, if the selected file cannot be uploaded because it is larger than the maximum upload size, we have to use the FTP upload method, but I cannot make it work.
Depending on the outcome of the debate raised by @brianteeman , this will require some work.
#27945 (comment)

avatar richard67
richard67 - comment - 23 Feb 2020

@wilsonge It seems we need a decision about FTP, if to keep it or if to drop it.

avatar twister65 twister65 - change - 29 Feb 2020
Labels Added: NPM Resource Changed ?
avatar wilsonge
wilsonge - comment - 1 Mar 2020

We're keeping it.

avatar twister65
twister65 - comment - 2 Mar 2020

I can't make it work with Joomla! 3.x too.
Upload and update Joomla! via FTP does not seem to work.
We have ftp options, but it is not functional.
Has anyone experienced this?

avatar twister65
twister65 - comment - 2 Mar 2020

As I understand it, we only use FTP to update (write) files on the server but not to upload the selected file.
In this case, this PR is ready to be tested. It should work like Joomla! 3.x.
Question: Do I have to create a new PR to implement the upload via FTP ?

avatar wilsonge
wilsonge - comment - 2 Mar 2020

As I understand it, we only use FTP to update (write) files on the server but not to upload the selected file.

Not as far as my understanding went (admittedly I've never tested FTP Modes). We use JFile::write https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_joomlaupdate/models/default.php#L443 (downloads) and JFile::upload when uploading a zip https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_joomlaupdate/models/default.php#L995

anything using JFile should respect the global configuration settings for FTP - that's the entire point of the JFile class to have the FTP wrapper

avatar twister65 twister65 - change - 3 Mar 2020
Title
[4.0] Supply the FTP details
[4.0] Upload & update Joomla via FTP
avatar twister65 twister65 - edited - 3 Mar 2020
avatar twister65 twister65 - change - 3 Mar 2020
The description was changed
avatar twister65 twister65 - edited - 3 Mar 2020
avatar twister65 twister65 - change - 3 Mar 2020
The description was changed
avatar twister65 twister65 - edited - 3 Mar 2020
avatar joomla-cms-bot joomla-cms-bot - change - 8 Mar 2020
Category Administration com_config com_joomlaupdate JavaScript Repository NPM Change Administration com_config com_joomlaupdate Language & Strings JavaScript Repository NPM Change
avatar twister65 twister65 - change - 8 Mar 2020
Labels Added: ?
avatar Quy
Quy - comment - 8 Mar 2020

Tested locally with XAMPP on Windows 10.

PHP Warning: fileowner(): stat failed for /tmp/330759cc93812163319df93121148c7f in \libraries\src\Filesystem\Path.php on line 279

avatar twister65
twister65 - comment - 15 Mar 2020

Tested locally with XAMPP on Windows 10.

PHP Warning: fileowner(): stat failed for /tmp/330759cc93812163319df93121148c7f in \libraries\src\Filesystem\Path.php on line 279

@Quy , which FTP server are you using in Windows 10 (XAMPP is just a web server) ? For example, with the Filezilla server, you must grant privileges to your FTP user.
Have you also correctly defined the root path of your joomla site in the global FTP configuration ?

avatar twister65 twister65 - change - 12 Jul 2020
Labels Added: Conflicting Files
avatar yasin-96 yasin-96 - test_item - 3 Aug 2020 - Tested unsuccessfully
avatar yasin-96
yasin-96 - comment - 3 Aug 2020

I have tested this item ? unsuccessfully on 0447602

So I could reproduce the issue but it does not occur every time you select the "write files directly" option. This does not happen when you switch to another option and then switch back to the write files directly option. If you for the first time en ther the tab and switch to that option for the first time when ur in the upload & update tab then this behavior occurs.

After I applied the patch and executed the command npm install this issues was not fixed and the same happened as like I didnt apply the patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28029.

avatar nurcihandem
nurcihandem - comment - 4 Aug 2020

Tested the patch by following the instructions. Selecting "Write files directly" causes the form fields always to disappear. Selecting second or third option will display the form fields. Is this the expected behaviour?

Previously, the form fields did disappear once. But after selecting around, the form fields were always displayed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28029.

avatar degobbis
degobbis - comment - 5 Aug 2020

Since the FTP credentials were implemented as a workaround for the wwwrun problem on web servers, such a server is necessary for a reliable test.

Windows with xampp is the wrong system for this.

A Unix based system with Apache and PHP as mod_php/apache2handler is required to test the correct use of FTP credentials.

Do we have testers with such a base here?

avatar twister65 twister65 - change - 8 Aug 2020
Labels Removed: Conflicting Files
avatar joomla-cms-bot joomla-cms-bot - change - 8 Aug 2020
Category Administration com_config com_joomlaupdate JavaScript Repository NPM Change Language & Strings Administration com_config com_joomlaupdate Language & Strings
avatar twister65 twister65 - change - 8 Aug 2020
The description was changed
avatar twister65 twister65 - edited - 8 Aug 2020
avatar twister65 twister65 - change - 8 Aug 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-08-08 13:53:04
Closed_By twister65
Labels Removed: NPM Resource Changed
avatar twister65 twister65 - close - 8 Aug 2020

Add a Comment

Login with GitHub to post a comment