Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#28018] - [4.0] Simplify ACL Check

? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
22 Feb 2020

Pull Request for Issue # .

Summary of Changes

  • In administrator/components/com_content/tmpl/articles/default.php, $canCreate permission is not used at all, so no need to calculate it for each article
  • In other controller classes, no need for define and and use $allow variable. The logic for checking add permission is simple: If Category ID is passed, check add permission of the category, otherwise, fallback to component permissio

Testing Instructions

Code review should be enough.

Documentation Changes Required

None

avatar joomdonation joomdonation - open - 22 Feb 2020
avatar joomdonation joomdonation - change - 22 Feb 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2020
Category ⇒ Administration com_banners com_contact com_content
avatar joomdonation joomdonation - change - 22 Feb 2020
Labels Added: ?
avatar joomdonation joomdonation - change - 22 Feb 2020
Title
…
Simplify ACL Check
[4.0] Simplify ACL Check
avatar joomdonation joomdonation - edited - 22 Feb 2020
05abca0 23 Feb 2020 avatar joomdonation CS
avatar wilsonge wilsonge - change - 2 Mar 2020
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-03-02 14:30:01
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 2 Mar 2020
avatar wilsonge wilsonge - merge - 2 Mar 2020
avatar wilsonge
wilsonge - comment - 2 Mar 2020

LGTM! Thankyou :)

Add a Comment

Login with GitHub to post a comment