? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
21 Feb 2020

Summary of Changes

Missed these in #27194. Casts XML element as string so strict comparison works properly.

Testing Instructions

Code review.
Or edit System - SEF plugin. In canonical domain field enter a URL without protocol (e.g. localhost).

Expected result

Value saved as http://localhost.

Actual result

Saving fails with error:

Invalid URL: URL schema is missing in localhost. Please add one of the following at the beginning: http, https, ftp, ftps, gopher, mailto, news, prospero, telnet, rlogin, sftp, tn3270, wais, mid, cid, nntp, tel, urn, ldap, file, fax, modem, git.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 21 Feb 2020
avatar SharkyKZ SharkyKZ - change - 21 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Feb 2020
Category Libraries
avatar Quy
Quy - comment - 21 Feb 2020

I have tested this item successfully on 62161bf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28006.

avatar Quy Quy - test_item - 21 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 21 Feb 2020

I have tested this item successfully on 62161bf

Testing of PR is good.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28006.

avatar jwaisner jwaisner - test_item - 21 Feb 2020 - Tested successfully
avatar jwaisner jwaisner - change - 21 Feb 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 21 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28006.

avatar rdeutz rdeutz - change - 22 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-22 17:45:07
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 22 Feb 2020
avatar rdeutz rdeutz - merge - 22 Feb 2020

Add a Comment

Login with GitHub to post a comment