Pending

User tests: Successful: Unsuccessful:

avatar phproberto
phproberto
17 Jul 2012

Fix propposed and accepted on:

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=28742

Please review compressed JS. I used an online YUI compressor and don't know if the format is correct.

avatar phproberto phproberto - open - 17 Jul 2012
avatar phproberto
phproberto - comment - 17 Jul 2012

I forgot to remove CSS that disables selects :)

avatar infograf768
infograf768 - comment - 17 Jul 2012

Needs testing first. Reports on joomlacode tracker.

avatar realityking
realityking - comment - 17 Jul 2012

3 things:
-Someone needs to make sure this has no negative effect on accessibility
-The comment explicit says this is used due to an IE issue. That means we need testing as far back as IE7 (2.5) or IE8 (3.0)
-All those files belong to the platform so it has to be submitted there as well.

avatar phproberto
phproberto - comment - 17 Jul 2012

The IE issue was a valuable information to share. That wasn't here or in joomlacode :(

Do you have a link with the issue reported with IE?

I have tested it on Joomla 3.0 + IE8 ( http://i50.tinypic.com/2zhnuo7.png ). Actually I haven't a VM with IE7. Can you test it?

Tested:

  • tabs skip disabled selects
  • selects remain unclickable
  • selects keep overlayed

I have no problem to submit it to platform after fully testing.

avatar realityking
realityking - comment - 17 Jul 2012

Yeah sorry about that, I just noticed the comment when I looked at your patch. The comment was already present in digitarald.de's original code so I have no isight why it was added. It might have been related to just IE6.

avatar phproberto
phproberto - comment - 18 Jul 2012

Also tested and working on IE7 & Joomla 2.5.6 :

http://i50.tinypic.com/5mkg07.png

Probably was related to IE6. Happy to read that :)

avatar andreatarr
andreatarr - comment - 25 Aug 2012

Tested on the alpha2 -- It works for the modals used in Hathor, but has no effect on Isis modals which I assume use different js.
I'd recommend committing to fix this issue with Hathor and to commit to 2.5 branch as well where it will fix both Hathor and Bluestork.

avatar phproberto
phproberto - comment - 16 Sep 2012

Thanks for testing this Andrea.

I've updated it to keep it actual. Waiting information about next steps or a reject message.

Thanks!

avatar vietvh vietvh - reference | - 17 Oct 12
avatar phproberto phproberto - close - 4 Oct 2013
avatar phproberto
phproberto - comment - 4 Oct 2013

Nobody cares about this :P

Closing

Add a Comment

Login with GitHub to post a comment