User tests: Successful: Unsuccessful:
Fix propposed and accepted on:
Please review compressed JS. I used an online YUI compressor and don't know if the format is correct.
Needs testing first. Reports on joomlacode tracker.
3 things:
-Someone needs to make sure this has no negative effect on accessibility
-The comment explicit says this is used due to an IE issue. That means we need testing as far back as IE7 (2.5) or IE8 (3.0)
-All those files belong to the platform so it has to be submitted there as well.
The IE issue was a valuable information to share. That wasn't here or in joomlacode :(
Do you have a link with the issue reported with IE?
I have tested it on Joomla 3.0 + IE8 ( http://i50.tinypic.com/2zhnuo7.png ). Actually I haven't a VM with IE7. Can you test it?
Tested:
I have no problem to submit it to platform after fully testing.
Yeah sorry about that, I just noticed the comment when I looked at your patch. The comment was already present in digitarald.de's original code so I have no isight why it was added. It might have been related to just IE6.
Also tested and working on IE7 & Joomla 2.5.6 :
http://i50.tinypic.com/5mkg07.png
Probably was related to IE6. Happy to read that :)
Tested on the alpha2 -- It works for the modals used in Hathor, but has no effect on Isis modals which I assume use different js.
I'd recommend committing to fix this issue with Hathor and to commit to 2.5 branch as well where it will fix both Hathor and Bluestork.
Thanks for testing this Andrea.
I've updated it to keep it actual. Waiting information about next steps or a reject message.
Thanks!
Nobody cares about this :P
Closing
I forgot to remove CSS that disables selects :)