[#27992] - [4.0] Update UCM component table classes
- Fixed in Code Base
- 12 Mar 2020
- Medium
- Build: 4.0-dev
- # 27992
- Diff
- SharkyKZ:j4/ucm/getContentTable
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
This updates entries in #__content_types table to include new fully qualified table class names.
Components that use JTable prefixed core classes are currently not included but maybe they should be. Looking for feedback on this.
Testing Instructions
This will need to be tested both for new installations and for upgrades from 3.10.
Create a contact, a newsfeed, a tag, a banner, a banner client and a user note.
Make some edits and save.
In the form, click Versions button and check whether the current version is marked with a star.
Expected result
Marked.
Actual result
Not marked.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin SQL Postgresql Installation |
| Labels |
Added:
?
|
||
I have tested this
- git fetch origin pull/27992/head:j4/ucm/getContentTable
- git checkout j4/ucm/getContentTable
- I made a new installation
- npm or composer is not needed.
- First I checked my mysql database. The changes are made.
6. Then I created a Tag, edited the Tag. But I could not see a Star. I think it is because the Table is not named TagsTable. The class is named TagTable (without the s),
7. I could see the star when I tried it with a Banner, a Contact and a Newsfeed.
I tested with the current 4.0.0-beta1-dev on Ubuntu with PHP 7.2 and MySQL 5.7.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-12 16:38:18 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Components that use JTable prefixed core classes are currently not included but maybe they should be. Looking for feedback on this.
I think they should be
Should we use the core classes or classes from components, e.g. Joomla\CMS\Table\Content or Joomla\Component\Content\Administrator\Table\ArticleTable. Asking this because I see both used throughout the CMS and not sure which one is the right way.
If there’s a component specific one use it.
I think I want to end up with components managing these things long terms anyhow so we can use the bootComponent methods for access anyhow.
@SharkyKZ In the update sql script for postgresql in the alter table statements you can't use
varchar, you have to usecharacter varyingbecause our database checker is so silly. In create table statements in update sql it doesn't mater because for these it doesn't check particular columns. See4.0.0-2018-07-29.sqlor4.0.0-2019-05-20.sqlfor examples on usage ofcharacter varying.