?
avatar TVBZ
TVBZ
19 Feb 2020

The menu item to add foreign URL has a Link rel attribute field in the Link Type tab.
The value noopener is missing from this list. If this could be added, that would be great.

Thanks!

avatar TVBZ TVBZ - open - 19 Feb 2020
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 19 Feb 2020
avatar TVBZ TVBZ - change - 19 Feb 2020
The description was changed
avatar TVBZ TVBZ - edited - 19 Feb 2020
avatar brianteeman
brianteeman - comment - 19 Feb 2020

rel="noopener" prevents the new page from being able to access the window.opener property and ensures it runs in a separate process.
rel="noreferrer" attribute has the same effect, but also prevents the Referer header from being sent to the new page. See Link type "noreferrer".

avatar TVBZ
TVBZ - comment - 19 Feb 2020

Huh. Okay, so it should also work. Thanks for clearing that out.

The question originated from trying to get my site to perform better in google LightHouse test.
It gives the warning to add rel="noopener" or rel="noreferer" to the link. After adding rel="noreferer", the warning remains. While in other links (from custom html) the warning disappeared after adding rel="noopener".

But I guess this is an issue for LightHouse than, and not Joomla :)

image

avatar brianteeman
brianteeman - comment - 19 Feb 2020

I actually copy pasted that information from lighthouse :)

avatar jwaisner jwaisner - change - 19 Feb 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-02-19 22:40:30
Closed_By jwaisner
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2020
Closed_By jwaisner joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 19 Feb 2020
avatar joomla-cms-bot
joomla-cms-bot - comment - 19 Feb 2020

Set to "closed" on behalf of @jwaisner by The JTracker Application at issues.joomla.org/joomla-cms/27990

avatar jwaisner
jwaisner - comment - 19 Feb 2020

Closing at this has been identified as not being related to Joomla!.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27990.

avatar TVBZ
TVBZ - comment - 20 Feb 2020

I'dd like to reopen this. After thinking some more on it ...
There are some cases where rel="noopener" is the only good option.
Because we don't want to lose the Referer header, rel="noreferer" just wont do.

avatar jwaisner jwaisner - change - 20 Feb 2020
Status Closed New
Closed_Date 2020-02-19 22:40:30
Closed_By joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - change - 20 Feb 2020
Closed_Date 0000-00-00 00:00:00
avatar joomla-cms-bot joomla-cms-bot - reopen - 20 Feb 2020
avatar joomla-cms-bot
joomla-cms-bot - comment - 20 Feb 2020
avatar jwaisner
jwaisner - comment - 20 Feb 2020

Reopened as per Author's request and new information provided.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27990.

avatar jwaisner jwaisner - change - 20 Feb 2020
Priority Medium Low
avatar Quy
Quy - comment - 20 Feb 2020

See #24337 for J4 and per the discussion it will not be fixed for J3. This should be closed and continue the discussion in the other issue.

avatar TVBZ
TVBZ - comment - 21 Feb 2020

I don't think it's the same issue. I don't mean to enforce this on all external url's.
It's just an option that's missing in the dropdown list for foreign URL menu type, in /administrator/components/com_menus/models/forms/item_url.xml.

For the field "menu-anchor_rel" (list type) this option should be added:
<option value="noopener"/>

That's all

avatar Quy
Quy - comment - 21 Feb 2020

@TVBZ Got it. Please test PR #28005. Thanks.

avatar Quy Quy - change - 21 Feb 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-02-21 18:12:30
Closed_By Quy
avatar Quy Quy - close - 21 Feb 2020

Add a Comment

Login with GitHub to post a comment