[#27971] - [4.0] Delete unused parameters and Language Strings
- Closed
- 1 Mar 2020
- Medium
- Build: 4.0-dev
- # 27971
- Diff
- astridx:deleteOptionString
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
I deleted the parameter options in from the XML files for menu items. If I am right, this parameter has no task at the moment.
I think that parameters, options and language strings should only be add if we use them and I think that unnecessary program code is not good for a software. In my opinion, it unsettles newbies if they want to learn using core extensions.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End com_config com_contact com_content com_newsfeeds com_tags com_users |
But is it being used?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27971.
Finally worked it out - I think
@SharkyKZ Thank you showing the place.
@brianteeman Thank you for checking and thinking along with me.
I honestly admit that I found the use only through SharkyKZ. Before, I only looked in the component menu. After posting the use in the code, however, I still think this is unnecessary. With my changes, the title is used instead of the option. For me, the title is clearer than Default. And mostly options and title are the same anyway.
I would not change the layout file
because theoption may be used by Third Party Extensions.
I leave the PR open for a few more days. If no one answers, I close it. Then I assume that I am the only one who likes the deletion.
have to agree that the title is more meaningful
The point here is to show the unique name of the layout, not the name of the view. It does not make sense to show "Single Contact" for default contact layout because every layout for the contact view fits the description.
| Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-01 22:36:02 |
| Closed_By | ⇒ | astridx |
These are used in component layout field.