? Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
15 Jan 2014

This change prevents the query from being executed when the value is 0. There is never an article with ID 0 and especially when there are more than one modal select per page, you have several unnecessary queries.

avatar Hackwar Hackwar - open - 15 Jan 2014
avatar Bakual
Bakual - comment - 15 Jan 2014

Can you add the tracker and some testing instructions?

avatar Bakual
Bakual - comment - 7 Feb 2014

especially when there are more than one modal select per page, you have several unnecessary queries.

Do we have this in core somewhere? Just asking for testing. The only place I know we have one modal is the menu item form for the single article view.

avatar Hackwar
Hackwar - comment - 7 Feb 2014

This is in multilang sites, where you have this field for every language in your site. So a site with 5 languages will have 4 of these fields in every new article.

avatar Bakual
Bakual - comment - 7 Feb 2014

This is in multilang sites, where you have this field for every language in your site. So a site with 5 languages will have 4 of these fields in every new article.

Ah thanks!

avatar infograf768
infograf768 - comment - 10 Feb 2014

Same should be done for contacts, newsfeeds, categories I guess.

avatar Hackwar
Hackwar - comment - 11 Feb 2014

Better? :-)

avatar infograf768
infograf768 - comment - 11 Feb 2014

There is a conflict with the category one

avatar Hackwar
Hackwar - comment - 11 Feb 2014

Should be good now.

avatar infograf768
infograf768 - comment - 15 Feb 2014

@wilsonge
Let's indeed normalise all these queries (not only these) in another PR.

avatar infograf768 infograf768 - change - 15 Feb 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-02-15 08:30:16
avatar infograf768 infograf768 - close - 15 Feb 2014
avatar infograf768 infograf768 - reference | 4219e4d - 15 Feb 14
avatar infograf768 infograf768 - merge - 15 Feb 2014
avatar infograf768 infograf768 - close - 15 Feb 2014
avatar Bakual Bakual - reference | d040d3f - 12 May 14
avatar Hackwar Hackwar - head_ref_deleted - 6 Jan 2016

Add a Comment

Login with GitHub to post a comment