I do not understand this PR. None of these xtensions in core contain an admin or site folder containing language files.

So, as the prefix of the language is now unused, we indeed need a change, but not by adding a folder.
instead of changing to

	<languages folder="admin">
		<language tag="en-GB">language/en-GB/mod_custom.ini</language>
		<language tag="en-GB">language/en-GB/mod_custom.sys.ini</language>
	</languages>

Should'nt we have

   <languages>
   	<language tag="en-GB">mod_custom.ini</language>
   	<language tag="en-GB">mod_custom.sys.ini</language>
   </languages>

@Bakual ?

As Brian noted, it doesn't really matter what is written there as it is not used anyway.
Since my own extensions all ship with the language files in their extension folder, I can't even say how it should be written if the languages go into the global folder. I just put a <folder>language</folder> tag in my XML ?

Since currently some XML have a path and some not, it certainly makes sense to do it all the same now. I just assume Brian had a look first which variant would be more correct.

exactly

@brianteeman May I ask you why you chose the longer variant.

When I looked at this PR, I thought the same thing as @infograf768. Therefore I would be interested in your reasons.

I followed the exact same syntax as used for components

Can you merge 4.0-dev into here to get drone rerunning please

Drone is all green now

@richard67 so it looks like the component version of this PR was merged and accepted but this one was closed

@richard67 so it looks like the component version of this PR was merged and accepted but this one was closed

@brianteeman Seems so .. but it was you who has closed it. What is right is that the "folder" attribute does not really belong to a file system folder but to the "folder" attribute for plugins like we have it in the extensions table in database. So these changes in this PR were wrong, but for sure we should fix the language file names. Do you wanna make a new PR for it?

Will do later.

Need to get my head around the folder

@brianteeman Look into the extensions helper or into the insert into extensions statements in base.sql and you will quickly get what the folder is.