? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Feb 2020

Updates the list of status codes as a few were missing. Ref https://developer.mozilla.org/en-US/docs/Web/HTTP/Status

Code review only

avatar brianteeman brianteeman - open - 14 Feb 2020
avatar brianteeman brianteeman - change - 14 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2020
Category Administration com_redirect
avatar brianteeman brianteeman - change - 14 Feb 2020
Labels Added: ?
avatar alikon
alikon - comment - 14 Feb 2020

may i suggest you to add 599
https://http.cat/599
image
more seriously https://httpstatuses.com/599

avatar alikon alikon - test_item - 14 Feb 2020 - Tested successfully
avatar alikon
alikon - comment - 14 Feb 2020

I have tested this item successfully on e81f580


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27931.

avatar brianteeman
brianteeman - comment - 14 Feb 2020

@alikon I have only included official status codes

avatar alikon
alikon - comment - 14 Feb 2020

sure don't mind,
i've seen it one time in my life much time ago, and i've laughed a lot

avatar ChristineWk
ChristineWk - comment - 14 Feb 2020

Sorry: Wanted to check Code review, but "Apply Patch" shows me:
The file marked for modification does not exist: administrator/components/com_redirect/src/Field/RedirectField.php
@alikon error 599 is nice :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27931.

avatar brianteeman
brianteeman - comment - 14 Feb 2020

@ChristineWk I think your branch is not up to date. With #27687 the files would have been moved

avatar ChristineWk
ChristineWk - comment - 14 Feb 2020

@brianteeman Thanks for your info. Will read and check above.
My "branch" is a fully nightly from 5thfeb2020.
So, I have to delete site and install again completely new installation (?)...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27931.

avatar brianteeman
brianteeman - comment - 14 Feb 2020

@ChristineWk I would recommend that for you as 2 days ago #27687 moved a lot of files

avatar ChristineWk
ChristineWk - comment - 14 Feb 2020

Hmmm. Will check ...... Thank you.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27931.

avatar ChristineWk
ChristineWk - comment - 15 Feb 2020

I have tested this item successfully on e81f580

... after installation completely fully branch of today ...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27931.

avatar ChristineWk ChristineWk - test_item - 15 Feb 2020 - Tested successfully
avatar Quy Quy - change - 15 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 15 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27931.

avatar Quy Quy - change - 16 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-16 02:42:08
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 16 Feb 2020
avatar Quy Quy - merge - 16 Feb 2020
avatar brianteeman
brianteeman - comment - 16 Feb 2020

thanks

Add a Comment

Login with GitHub to post a comment