NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar angieradtke
angieradtke
14 Feb 2020

Summary of Changes

Changes of CSS for better UX - make options always visible for a better understanding

Testing Instructions

go to article edit and take look at the featured options

b0336e5 6 Feb 2020 avatar angieradtke card
avatar angieradtke angieradtke - open - 14 Feb 2020
avatar angieradtke angieradtke - change - 14 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2020
Category Administration Templates (admin) Repository NPM Change
avatar rdeutz rdeutz - change - 14 Feb 2020
Title
Switcher ui
[4.0] Switcher ui
avatar rdeutz rdeutz - edited - 14 Feb 2020
avatar rdeutz rdeutz - change - 14 Feb 2020
Labels Added: NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 14 Feb 2020

@rdeutz your attempt to remove _variables.css from this PR has instead deleted it from the branch

avatar rdeutz
rdeutz - comment - 14 Feb 2020

@brianteeman I am already looking into this to fix my mistake

avatar brianteeman
brianteeman - comment - 14 Feb 2020

I am not in favour of this change. It makes the screen much busier than it needs to be and it makes it harder to scan a page with a lot of options (sadly we have a lot of those pages)

avatar rdeutz
rdeutz - comment - 14 Feb 2020

closing this one here and making a new one because I messed it up

avatar rdeutz rdeutz - change - 14 Feb 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-02-14 16:13:30
Closed_By rdeutz
avatar rdeutz rdeutz - close - 14 Feb 2020
avatar angieradtke
angieradtke - comment - 14 Feb 2020

oh I see the code in the global- config etc is different - so there it isn't working- I have to made some adaptions

avatar brianteeman
brianteeman - comment - 14 Feb 2020

@rdeutz Don't bother to remake it - we already have code for this

image

		<field
			name="featured"
			type="radio"
			label="JFEATURED"
			layout="joomla.form.field.radio.buttons"
			default="0"
			class="btn-group btn-group-yesno"
			>
			<option value="0">JNO</option>
			<option value="1">JYES</option>
		</field>
```'


avatar Bakual
Bakual - comment - 14 Feb 2020

layout="joomla.form.field.radio.buttons"

You actually can even remove that line, because this is the default layout anyway.

Just for reference: I've suggested getting rid of the switcher and using the btn-groups again back in 2017 with #15946. You can read the comments there
I can always update and reactivate it if there is some interest.

avatar Bakual
Bakual - comment - 16 Feb 2020

I redid the "Revert Switcher" PR so you can have a look ?
#27952

Add a Comment

Login with GitHub to post a comment