Feeling Lucky
?
[#27923] - [4.0] Clean up module chromes
- Fixed in Code Base
- 16 Feb 2020
- Medium
- Build: 4.0-dev
- # 27923
- Diff
- SharkyKZ:j4/cleanup/module-chromes
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27922.
Summary of Changes
Remove MooTools based chromes.
Move inline CSS to file.
Use early returns.
Minor syntax cleanups.
Testing Instructions
Test that different module chromes still work.
Documentation Changes Required
sliders and tabs chromes removed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Repository NPM Change Layout Front End Templates (site) |
Twincarb
- comment
- 14 Feb 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27923.
jwaisner
- comment
- 14 Feb 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27923.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 14 Feb 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27923.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-16 08:54:23 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested and can confirm that:
Initial fault is now cleared, unable to select sliders or tabs as they are now removed - is this going to be a backwards compatability break with sites that currently use them which needs documenting?
Additional checks due to other changes
I confirm that outline.css is active when outline is selected
Clean up html5 - when html 5 is selected it works as expected with no noticable issues
Clean up Cassiopeia chromes - when selecting default or card grey it works with no noticable issues
Clean up Atum chromes - no noticable issues in the backend with the changes
Minor Cleanups - I cant see any issues rendering pages, and a code review appears fine
htmlspecialchars() - Not sure what I should look for here, I can't see anything having broken in the back end when looking at and checking the code produced.
If I have covered all the areas needed I am happy to mark this as tested successfully, unless someone can identify and other checks required.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27923.