? ? Pending

User tests: Successful: Unsuccessful:

avatar shubhamshubh
shubhamshubh
12 Feb 2020

Pull Request for Issue #27674 .

Summary of Changes

I have set the overflow of container-main class as auto because under articles, it had too many options and two scroll bars can be seen on the page. Also, on expanding the sidebar, the content on the RHS wasn't getting diminished.

Testing Instructions

Run npm build run:css after merging changes and clear browser's cache

Expected result

No additional Scroll Bar

Actual result

Expected Result Achived

Documentation Changes Required

None.

avatar shubhamshubh shubhamshubh - open - 12 Feb 2020
avatar shubhamshubh shubhamshubh - change - 12 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2020
Category Administration Templates (admin)
avatar shubhamshubh shubhamshubh - change - 12 Feb 2020
Title
Ss comcontentoptions
[4.0] Hiding the overflow of container.main class
avatar shubhamshubh shubhamshubh - edited - 12 Feb 2020
avatar shubhamshubh shubhamshubh - change - 12 Feb 2020
Labels Added: ?
avatar brianteeman brianteeman - test_item - 12 Feb 2020 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 12 Feb 2020

I have tested this item ? unsuccessfully on d19ded5

Unfortunately this is not the correct solution as it effects other areas. After applying the PR got the article manager and you will see that (on the relevant sized screen) some of the columns on the right completely disappear. Not my area of skill but I would look at making your change more specific


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27899.

avatar shubhamshubh
shubhamshubh - comment - 12 Feb 2020

@brainteeman, Yup!.. I checked what you have mentioned. If we set "overflow: auto" then both the issues are resolved!..


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27899.

avatar brianteeman
brianteeman - comment - 12 Feb 2020

that works

avatar shubhamshubh
shubhamshubh - comment - 12 Feb 2020

Should I edit in this PR or should I open another one and close this one?

avatar brianteeman
brianteeman - comment - 12 Feb 2020

edit this one

avatar shubhamshubh shubhamshubh - change - 12 Feb 2020
The description was changed
avatar shubhamshubh shubhamshubh - edited - 12 Feb 2020
avatar brianteeman brianteeman - test_item - 12 Feb 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Feb 2020

I have tested this item successfully on 7dca1a7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27899.

avatar chmst
chmst - comment - 13 Feb 2020

I have tested this item successfully on 7dca1a7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27899.

avatar chmst chmst - test_item - 13 Feb 2020 - Tested successfully
avatar Quy Quy - change - 13 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27899.

avatar wilsonge wilsonge - change - 13 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-13 15:57:34
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 13 Feb 2020

Thanks!

Add a Comment

Login with GitHub to post a comment