[#27896] - Fix error in custom field form on PHP 5.3
- Fixed in Code Base
- 27 Feb 2020
- Medium
- Build: staging
- # 27896
- Diff
- SharkyKZ:patch-2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes error on PHP 5.3.
Testing Instructions
Create a custom field.
Expected result
No errors.
Actual result
Parse error: syntax error, unexpected '[' in administrator\components\com_fields\models\fields\fieldlayout.php on line 39
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
Do I understand correctly that this PR should be tested especially under PHP 5.3?
I copied the code from this PR and created a Custom Field with the current 4.0.0-beta1-dev on Ubuntu with PHP 7.2 and MySQL 5.7. That was successful. Should I add this test in the tacker?
if i understand correctly this pr is for staging where we still claim to be 5.3.10 as a minimum requirements
for j4 the minimum should be 7.2.5
so should be tested on 3.x branch
I have tested this item
Code review.
(There is no XAMPP that matches 5.3 but higher/equal 5.3.10).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27896.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27896.
RTC
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27896.
laoneo
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-27 13:20:14 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
?
|
||
There really should be a CI step linting files to make sure they stay compatible with a given PHP version. Or, just stop claiming PHP 5.3 compatibility; not only is it wasting people's time these days but there are 2-3 releases per year with bug fixes specifically for that PHP version.