? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
11 Feb 2020

The display of the user name in the user dropdown menu looks a little off due to lack of styling.

This add an icon before the username and the text "signed in as " as a prefix. (The text is as used on github)

There are css changes so npm i or node buuld.js --compile-css

Before

image

After

image

Apologies to @chmst I think you suggested somethign like this before and I was not in favour - I was wrong.

avatar brianteeman brianteeman - open - 11 Feb 2020
avatar brianteeman brianteeman - change - 11 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2020
Category Administration Language & Strings Modules Templates (admin)
avatar brianteeman brianteeman - change - 11 Feb 2020
Labels Added: ? ?
avatar Quy
Quy - comment - 11 Feb 2020

Is the added css still required?

avatar brianteeman
brianteeman - comment - 11 Feb 2020

yes because thats the same css as on the items below the header

avatar brianteeman
brianteeman - comment - 11 Feb 2020

drone failures are the usual

avatar brianteeman
brianteeman - comment - 11 Feb 2020

@SharkyKZ thanks - wasn't thinking correctly this morning obviously

avatar Quy Quy - test_item - 11 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 11 Feb 2020

I have tested this item successfully on 5f0b323


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27893.

avatar jwaisner jwaisner - test_item - 11 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 11 Feb 2020

I have tested this item successfully on 5f0b323


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27893.

avatar jwaisner jwaisner - change - 11 Feb 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 11 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27893.

avatar rdeutz rdeutz - change - 12 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-12 08:19:11
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 12 Feb 2020
avatar rdeutz rdeutz - merge - 12 Feb 2020
avatar brianteeman
brianteeman - comment - 12 Feb 2020

thanks

Add a Comment

Login with GitHub to post a comment