Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#2789] - Implementing caching for getRootId() to save queries

? Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
14 Jan 2014

The method getRootId() is executed numerous times per page load, for example when editing an article around 20 times. At the same time, that method always returns the same value. By adding a static variable as cache, we save us all those duplicate queries and they are only run once per table.

avatar Hackwar Hackwar - open - 14 Jan 2014
avatar Hackwar
Hackwar - comment - 24 Feb 2014

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33333&start=0

Oh, and: WOOHOO!! 5 times 3 as the tracker ID! ;-)

avatar wilsonge
wilsonge - comment - 26 Feb 2014

@test works (this is like the 3rd/4th attempt to fix this - except this actually works) so much awesomeness - thanks Hannes.

avatar mbabker mbabker - reference | - 8 Apr 14
avatar mbabker
mbabker - comment - 8 Apr 2014

Merged to 3.3-dev at ce8f7ec

avatar mbabker mbabker - change - 8 Apr 2014
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-04-08 23:38:31
avatar mbabker mbabker - close - 8 Apr 2014
avatar mbabker mbabker - close - 8 Apr 2014
avatar Bakual Bakual - reference | - 12 May 14
avatar Hackwar Hackwar - head_ref_deleted - 10 Dec 2014

Add a Comment

Login with GitHub to post a comment