? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
9 Feb 2020

Summary of Changes

Adding missing string in case a content language can't be created when installing a language during J installation

Saw this when testing #25258 (comment) on a clean install.

Issue will normally be solved by #27854 but better be safe in case a Content Language can't be created at J installation time.

@richard67

avatar infograf768 infograf768 - open - 9 Feb 2020
avatar infograf768 infograf768 - change - 9 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2020
Category Installation Language & Strings
avatar richard67
richard67 - comment - 9 Feb 2020

@infograf768 I haven't seen that warning, not translated and not untranslated, and this PR here seems to deal with new installation. Shall we do real test or do code review only? Please provide instructions.

avatar richard67
richard67 - comment - 9 Feb 2020

@infograf768 Forget my previous question. Got it. Am just testing.

avatar richard67 richard67 - test_item - 9 Feb 2020 - Tested successfully
avatar richard67
richard67 - comment - 9 Feb 2020

I have tested this item successfully on e946049

On a clean current 4.0-dev branch as long as PR #27854 hasn't been merged yet, make a new installation.
At the end of installation, customize installation and install e.g. Persian language.
Result: Notice alert shown.
Without PR notice not translated but showing the language string constant.
pr-27870_1

With this PR: OK, correct message is shown.
pr-27870_2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27870.
avatar infograf768
infograf768 - comment - 9 Feb 2020

This new string is just a precaution. There are many possible reasons why a content language could not be created.

avatar wilsonge wilsonge - close - 9 Feb 2020
avatar wilsonge wilsonge - merge - 9 Feb 2020
avatar wilsonge wilsonge - change - 9 Feb 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-09 17:00:05
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 9 Feb 2020

Thanks!

Add a Comment

Login with GitHub to post a comment