Joomla! Issue Tracker | Joomla! CMS #2787 - Use query builder in JUpdater->findUpdates()

Closed
27 Jul 2014
Medium
Build: staging
# 2787
Diff
Bakual:UseQueryBuilderInJUpdater

Success

Success The Travis CI build passed Details

User tests: Successful: Unsuccessful:

Bakual
13 Jan 2014

Testing instructions

Make sure that Joomla updates and extensions updates are found after the patch is applied.

Proposed Changes

Change the $query to use the querybuilder.
Use an inner join instead of a subselect
Do a proper filter if $eid is passed as a single integer. Currently it is expected as an array of integers and will do no filtering at all if a single integer is passed instead of an array. Instead it will search for updates in all sites, slowing down the process. We pass a single integer in some places, like in the Joomla Update component. Thus this should be a bit faster with this patch.

Bakual - open - 13 Jan 2014

Bakual - comment - 13 Jan 2014

Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33116

07ec5ad 12 May 2014

Use Querybuilder for JUpdater->findUpdates()

498d2eb 12 May 2014

Missed table identifier for the extra_query

5404478 26 Jul 2014

Check first if $eid is array and if not try to cast to int.

Bakual - change - 26 Jul 2014

Description

<h3>Testing instructions</h3> <p>Make sure that Joomla updates and extensions updates are found after the patch is applied.</p> <h3>Proposed Changes</h3> <ul> <li>Change the <code>$query</code> to use the querybuilder.</li> <li>Use an inner join instead of a subselect</li> <li>Do a proper filter if <code>$eid</code> is passed as a single integer. Currently it is expected as an array of integers and will do no filtering at all if a single integer is passed instead of an array. Instead it will search for updates in all sites, slowing down the process. We pass a single integer in some places, like in the Joomla Update component. Thus this should be a bit faster with this patch.</li> </ul>

⇒

<h3>Testing instructions</h3> <p>Make sure that Joomla updates and extensions updates are found after the patch is applied.</p> <h3>Proposed Changes</h3> <ul class="task-list"> <li>Change the <code>$query</code> to use the querybuilder.</li> <li>Use an inner join instead of a subselect</li> <li>Do a proper filter if <code>$eid</code> is passed as a single integer. Currently it is expected as an array of integers and will do no filtering at all if a single integer is passed instead of an array. Instead it will search for updates in all sites, slowing down the process. We pass a single integer in some places, like in the Joomla Update component. Thus this should be a bit faster with this patch.</li> </ul>