NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
9 Feb 2020

Codemirror was locked at a specific version that is now very old.

This PR changes the setting in package.json so that it follows semver

Codemirror has always been very good at following semver so this should be totally safe.

(the update process also updated tinymce at the same time)

avatar brianteeman brianteeman - open - 9 Feb 2020
avatar brianteeman brianteeman - change - 9 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2020
Category NPM Change Front End Plugins
avatar Quy Quy - test_item - 9 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 9 Feb 2020

I have tested this item successfully on 6bfb5d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27868.

avatar richard67 richard67 - test_item - 9 Feb 2020 - Tested successfully
avatar richard67
richard67 - comment - 9 Feb 2020

I have tested this item successfully on 6bfb5d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27868.

avatar richard67 richard67 - change - 9 Feb 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 9 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27868.

avatar richard67 richard67 - change - 9 Feb 2020
Labels Added: ? ? NPM Resource Changed
avatar richard67
richard67 - comment - 9 Feb 2020

@wilsonge @brianteeman I just see some "resolved" links in file package-lock.json have changed from https:// to http://. Is this ok or should these changes be reverted?

avatar wilsonge
wilsonge - comment - 9 Feb 2020

I think that's somehow based on OS or something it seems to change all the time. It's not ideal but it's not the end of the world either

avatar rdeutz rdeutz - change - 10 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-10 07:21:42
Closed_By rdeutz
Labels
avatar rdeutz rdeutz - close - 10 Feb 2020
avatar rdeutz rdeutz - merge - 10 Feb 2020
avatar brianteeman
brianteeman - comment - 10 Feb 2020

Thnks

Add a Comment

Login with GitHub to post a comment