[#27864] - [4.0] Fix background shorthand incompatibilities
- Fixed in Code Base
- 12 Feb 2020
- Medium
- Build: 4.0-dev
- # 27864
- Diff
- infograf768:4.0_background_compat
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27572
Replaces #27798
Summary of Changes
Separating background color and background image in CSS to allow loading the specific .svg in Safari and Edge.
Testing Instructions
Use Safari or Windows Edge.
Log in administration area.
Go to Articles.
Click Filter Options.
Click Select Condition dropdown and select a condition.
Selected item has no down arrow.
Apply PR.
USE NPM
Repeat steps above.
Selected items have down arrow.
Confirm with other browsers such as Firefox, Chrome work correctly as before.
Repeat for RTL.
Before patch
After patch
UPDATED as it should now work in Safari
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
@Quy
Please test RTL now both in Safari and other browsers
(Make sure cache is deleted for each browser)
NOTE: the select-bg-rtl.svg now contains the default background color used by Atum.
fill="#1a466b"
if this background color is modified in the future, the value in the svg should be modified to fit
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27864.
When in RTL and with a custom hue selected in the admin template this doesnt work 100%
When in RTL and with a custom hue selected in the admin template this doesnt work 100%
Understand. If someone finds a solution, then please propose.
Grrr. found out the issue...
My first try was minified which killed it.
Will update this pr tomorrow.
@Quy @brianteeman
Please test again. svg corrected.
| Title |
|
||||||
Looks good except here. Edit an article. This is chosen that you mentioned requires fixing.
That just means we have to add a dir rtl there. On it.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27864.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27864.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27864.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-12 19:55:01 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@vistamedia @C-Lodder @ciar4n