NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
9 Feb 2020

Summary of Changes

Revert #27466

Currently

grafik

After patch + npm

grafik

Testing Instructions

Open the TinyMCE plugin and check the position of the elements.

Expected result

Everything aligned

Actual result

Everything is left outside

@brianteeman could you please check, because you added the margin for a reason. Perhaps my settings are wrong (latest Firefox)

avatar bembelimen bembelimen - open - 9 Feb 2020
avatar bembelimen bembelimen - change - 9 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2020
Category Repository NPM Change
avatar bembelimen bembelimen - change - 9 Feb 2020
Title
Remove negative margin in tinymce builder
[4.0] Remove negative margin in tinymce builder
avatar bembelimen bembelimen - edited - 9 Feb 2020
avatar Fedik
Fedik - comment - 9 Feb 2020

yeah, that was changed in #27684
negative margin no need now

avatar richard67 richard67 - test_item - 9 Feb 2020 - Tested successfully
avatar richard67
richard67 - comment - 9 Feb 2020

I have tested this item successfully on 723fb1a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27862.

avatar Fedik Fedik - test_item - 9 Feb 2020 - Tested successfully
avatar Fedik
Fedik - comment - 9 Feb 2020

I have tested this item successfully on 723fb1a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27862.

avatar richard67 richard67 - change - 9 Feb 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 9 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27862.

avatar richard67 richard67 - change - 9 Feb 2020
Labels Added: ? ? NPM Resource Changed
avatar Quy Quy - change - 9 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-09 13:49:14
Closed_By Quy
Labels
avatar Quy Quy - close - 9 Feb 2020
avatar Quy Quy - merge - 9 Feb 2020

Add a Comment

Login with GitHub to post a comment