[#27859] - [4.0] Center modal on mobile
- Fixed in Code Base
- 9 Feb 2020
- Medium
- Build: 4.0-dev
- # 27859
- Diff
- brianteeman:mobile_modal
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27536 .
Summary of Changes
Bizarrely bootstrap does not center modals on devices smaller than 567px eg mobile phones
Testing Instructions
Go to the admin dashboard
Reduce viewport width down to a mobile size
Click the "Add module to the dashboard" button at the bottom of the page
Expected result
Horizontally aligned modal
Actual result
Modal aligned to the left
apply the pr run npm i or node build.js --compile-css
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27859.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27859.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-09 18:18:42 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks.
thanks
I don't agree with this change. I think changes should never be made in the vendor directory but in the overrides.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27859.
@chmst I think you are right. It should have been modified here:
\administrator\templates\atum\scss\blocks\_modals.scss
@brianteeman Could you check and if necessary make a new PR?
This PR was correct
Your changes are correct.
But the code would be easier maintain if you could do them in scss/blocks/_modals where all the overrides for modals are.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27859.
That's the problem with us having two different places where code is being overridden. It would be easier to maintain if there was only one place and not two.
It is indeed very confusing where to modify/change stuff for this template.
The question is: are you willing to make a PR to move the code to \administrator\templates\atum\scss\blocks\_modals.scss or not.
If you are not willing to, no problem, I will do.
If the code is moved then all the code in that vendor folder should be moved as well and the imports removed
and/or it should be clearly documented when to use the vendor folder
Well, this case is quite clear:
atum vendor modal only deals with jviewport stuff
blocks/modal deals with all specific modal classes. btn, header, body, title, etc.
Therefore .modal-dialog should also be there.
clear as mud. the logic behind the decision escapes me
i dont see how you come to the conclusion that it is in the wrong place
I give up.
@brianteeman putting modal overrides in modals ( \administrator\templates\atum\scss\blocks\_modals.scss )
makes perfect sense to me. I get that it's confusing but it can be fixed one bite at a time. Lets at least get the ball rolling by putting your pr there.
I hope that makes sense to you.
Just for clarity - it is not an override
I have tested this item✅ successfully on 71b426d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27859.