[#27851] - [4.0] Include resize modal markup for image type only
- Fixed in Code Base
- 8 Feb 2020
- Medium
- Build: 4.0-dev
- # 27851
- Diff
- Quy:27846-templates
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27846.
Summary of Changes
Resize modal markup outputs for all file types where height/width values were null for non-image types. This PR restricts markup to image type only.
Affected on PHP 7.4+
Testing Instructions
Go to System > Site Templates
Click Cassiopeia Details and Files
Edit a file that is not an image.
View page source
Find id="resizeModal"
See errors in PHP log
Apply PR
View page source
Find id="resizeModal" but not found
No errors in PHP log
Actual result
PHP Notice: Trying to access array offset on value of type null in \administrator\components\com_templates\tmpl\template\default_modal_resize_body.php on line 25
PHP Notice: Trying to access array offset on value of type null in\administrator\components\com_templates\tmpl\template\default_modal_resize_body.php on line 35
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27851.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27851.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-08 19:08:47 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 18af308
Tested on PHP 7.4.2.
Markup
id="resizeModal"is only shown for images, and PHP warning for non-images has gone.This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27851.