? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
7 Feb 2020

This PR updates a few packages that clearly follow semver

Summary of Changes

Testing Instructions

avatar brianteeman brianteeman - open - 7 Feb 2020
avatar brianteeman brianteeman - change - 7 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2020
Category NPM Change
avatar jwaisner
jwaisner - comment - 7 Feb 2020

@brianteeman Is this code review or do we need test results?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27848.

avatar wilsonge
wilsonge - comment - 8 Feb 2020

In terms of the changes to package.json it's fine. just do some basic testing of tinymce loading, choices loading and for a stretch minicolours

avatar Quy Quy - test_item - 8 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 8 Feb 2020

I have tested this item successfully on c682404


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27848.

avatar jwaisner jwaisner - test_item - 8 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 8 Feb 2020

I have tested this item successfully on c682404


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27848.

avatar jwaisner jwaisner - change - 8 Feb 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 8 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27848.

avatar wilsonge wilsonge - change - 9 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-09 00:25:38
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 9 Feb 2020
avatar wilsonge wilsonge - merge - 9 Feb 2020
avatar wilsonge
wilsonge - comment - 9 Feb 2020

Thankyou!

avatar brianteeman
brianteeman - comment - 9 Feb 2020

Thanks

Add a Comment

Login with GitHub to post a comment