NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
7 Feb 2020

Codemirror was locked at a specific version that is now very old.

This PR changes the setting in package.json so that it follows semver

Codemirror has always been very good at following semver so this should be totally safe.

(the update process also updated tinymce at the same time)

Our implementation of codemirror is currently broken #27832 and that is unrelated to this. Check that the codemirror and tinymce xml files are updated with the correct version

avatar brianteeman brianteeman - open - 7 Feb 2020
avatar brianteeman brianteeman - change - 7 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2020
Category NPM Change Front End Plugins
avatar richard67
richard67 - comment - 9 Feb 2020

@brianteeman It seems the merge of your semver PR causes conflicts here now? Could you solve them? Would make it easier for people to test this PR here. Thanks in advance, and let me know if assistance needed ;-)

avatar brianteeman brianteeman - change - 9 Feb 2020
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2020
Category NPM Change Front End Plugins Administration com_config com_contact com_content com_cpanel com_finder com_languages com_menus com_newsfeeds com_tags com_templates Language & Strings Modules Templates (admin)
avatar brianteeman brianteeman - change - 9 Feb 2020
Labels Added: ?
Removed: NPM Resource Changed
avatar brianteeman brianteeman - change - 9 Feb 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-02-09 13:50:40
Closed_By brianteeman
avatar brianteeman brianteeman - close - 9 Feb 2020
avatar richard67
richard67 - comment - 9 Feb 2020

yes, redo is easier in some case ;-)

avatar brianteeman brianteeman - change - 9 Feb 2020
Status Closed New
Closed_Date 2020-02-09 13:50:40
Closed_By brianteeman
avatar brianteeman brianteeman - change - 9 Feb 2020
Status New Pending
avatar brianteeman brianteeman - reopen - 9 Feb 2020
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2020
Category Administration com_config com_contact com_content com_cpanel com_finder com_languages com_menus com_newsfeeds com_tags com_templates Language & Strings Modules Templates (admin) NPM Change Front End Plugins
avatar brianteeman brianteeman - change - 9 Feb 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-02-09 13:54:11
Closed_By brianteeman
Labels Added: NPM Resource Changed
Removed: ?
avatar brianteeman brianteeman - close - 9 Feb 2020
avatar brianteeman
brianteeman - comment - 9 Feb 2020

i will do it later

avatar richard67
richard67 - comment - 9 Feb 2020

Ok, just ping when test needed.

Add a Comment

Login with GitHub to post a comment