NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 Feb 2020

This PR ensures that the position of the colorpicker is positioned correctly by increasing the specificity of the css AND making sure it is actually imported. It also ensures that the pointer is used and not the I-beam

PR for #27538
npm -i as it is a css change

Further details in the report #27538

avatar brianteeman brianteeman - open - 6 Feb 2020
avatar brianteeman brianteeman - change - 6 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2020
Category Administration Templates (admin) Repository NPM Change
avatar C-Lodder
C-Lodder - comment - 6 Feb 2020
avatar brianteeman
brianteeman - comment - 6 Feb 2020

thats the vendor supplied css not the override

avatar C-Lodder
C-Lodder - comment - 6 Feb 2020

ah my bad

avatar jwaisner jwaisner - test_item - 6 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 6 Feb 2020

I have tested this item successfully on 947d88d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27829.

avatar jwaisner jwaisner - change - 7 Apr 2020
Priority Medium Low
avatar richard67
richard67 - comment - 11 Apr 2020

I have tested this item successfully on 947d88d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27829.

avatar richard67 richard67 - test_item - 11 Apr 2020 - Tested successfully
avatar richard67 richard67 - change - 11 Apr 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27829.

avatar richard67 richard67 - change - 11 Apr 2020
Labels Added: ? ? NPM Resource Changed
avatar dgrammatiko
dgrammatiko - comment - 11 Apr 2020

@richard67 RTC? Really??? Did you ready any of my comments?

avatar richard67
richard67 - comment - 11 Apr 2020

@dgrammatiko Yes I did read them but I'm not deep enough into these things to tell what is right and what is wrong. I only can see this PR solves an issue.

@wilsonge Should I revert the RTC until the discussion is clarified?

avatar richard67
richard67 - comment - 11 Apr 2020

@C-Lodder What's your opinion?

avatar wilsonge wilsonge - change - 11 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-11 21:23:58
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 11 Apr 2020
avatar wilsonge wilsonge - merge - 11 Apr 2020
avatar wilsonge
wilsonge - comment - 11 Apr 2020

This will do. It can be followed up with a vendor specific override in a future PR

avatar brianteeman
brianteeman - comment - 11 Apr 2020

thanks <200 now

Add a Comment

Login with GitHub to post a comment