User tests: Successful: Unsuccessful:
Pull Request for Issue #26771
Fixed styling issue with Save & Close button on mobile on article page
The content in "Save and Close" button should be aligned properly.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) |
The intended design is for all those buttons to be 100% width on a mobile
@richard67 I have changed it and am sorry for the improper message.
@brianteeman Would this be good?
yes that is the intended design
Looks good but has to be tested in RTL and with other pages.
Labels |
Added:
?
|
@brianteeman @richard67 @infograf768 Is this fine?
@richard67 I have changed it and am sorry for the improper message.
No need to say sorry. I've explained how we normally do it, you followed that, so all is fine.
Almost there.
Remains to modify line 383 of /administrator/templates/atum/scss/blocks/_toolbar.scss
from
@include media-breakpoint-down(sm) {
[dir=rtl] & {
margin-left: 0.75rem;
margin-right: 0 !important;
}
}
to
@include media-breakpoint-down(sm) {
[dir=rtl] & {
margin-left: 0.75rem !important; // Added !important
margin-right: 0 !important;
}
}
before this modification, we get
after this modification, we get
I have tested this item
Looks OK now to me.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-06 18:22:18 |
Closed_By | ⇒ | infograf768 | |
Labels |
Added:
?
|
tks
Title |
|
@Subhang23 Our Pull Request (PR) template provides 2 pre-defined section, "Expected result" and "Actual result". "Expected result" shall describe what is the right, expected behavior which is approached with the PR, i.e. the result after having applied the PR. "Actual result" shall describe the current, actual behavior of Joomla (3 or 4, depending on which version the PR is made for, in case of this PR: 4).
Now you used "Present result" and "Actual result" in this PR.
Due to a certain ambiguity of the English language for that word, "Present" can be a verb and mean "to show something to someone", but it also can be an adjective and mean (almost) same as "current" or "actual". So for a quick reader it is not really clear which of your screenshots shows the situation before and which one shows the sitation after applying your PR.
Of course one could test to find it out, but for readers it would be better if it would be more clear.
Could you correct the section headings above your screenshots so that it is like I described above, "Actual result" for what we have in Joomla 4 now, and "Expected result" for how it with your PR aplied?
Thanks in advance.