? ? Pending

User tests: Successful: Unsuccessful:

avatar Subhang23
Subhang23
5 Feb 2020

Pull Request for Issue #26771

Summary of Changes

Fixed styling issue with Save & Close button on mobile on article page

Testing Instructions

Expected result

The content in "Save and Close" button should be aligned properly.

Actual result

Screenshot from 2020-02-05 18-24-09

Documentation Changes Required

avatar Subhang23 Subhang23 - open - 5 Feb 2020
avatar Subhang23 Subhang23 - change - 5 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Feb 2020
Category Administration Templates (admin)
avatar Subhang23 Subhang23 - change - 5 Feb 2020
The description was changed
avatar Subhang23 Subhang23 - edited - 5 Feb 2020
avatar Subhang23 Subhang23 - change - 5 Feb 2020
The description was changed
avatar Subhang23 Subhang23 - edited - 5 Feb 2020
avatar richard67
richard67 - comment - 5 Feb 2020

@Subhang23 Our Pull Request (PR) template provides 2 pre-defined section, "Expected result" and "Actual result". "Expected result" shall describe what is the right, expected behavior which is approached with the PR, i.e. the result after having applied the PR. "Actual result" shall describe the current, actual behavior of Joomla (3 or 4, depending on which version the PR is made for, in case of this PR: 4).

Now you used "Present result" and "Actual result" in this PR.

Due to a certain ambiguity of the English language for that word, "Present" can be a verb and mean "to show something to someone", but it also can be an adjective and mean (almost) same as "current" or "actual". So for a quick reader it is not really clear which of your screenshots shows the situation before and which one shows the sitation after applying your PR.

Of course one could test to find it out, but for readers it would be better if it would be more clear.

Could you correct the section headings above your screenshots so that it is like I described above, "Actual result" for what we have in Joomla 4 now, and "Expected result" for how it with your PR aplied?

Thanks in advance.

avatar brianteeman
brianteeman - comment - 5 Feb 2020

The intended design is for all those buttons to be 100% width on a mobile

avatar Subhang23 Subhang23 - change - 5 Feb 2020
The description was changed
avatar Subhang23 Subhang23 - edited - 5 Feb 2020
avatar Subhang23
Subhang23 - comment - 5 Feb 2020

@richard67 I have changed it and am sorry for the improper message.

avatar Subhang23
Subhang23 - comment - 5 Feb 2020

@brianteeman Would this be good?
Screenshot from 2020-02-05 22-07-43

avatar brianteeman
brianteeman - comment - 5 Feb 2020

yes that is the intended design

avatar infograf768
infograf768 - comment - 5 Feb 2020

Looks good but has to be tested in RTL and with other pages.

avatar Subhang23 Subhang23 - change - 5 Feb 2020
Labels Added: ?
avatar brianteeman
brianteeman - comment - 5 Feb 2020

Unfortunately this breaks the action button

image

avatar brianteeman
brianteeman - comment - 5 Feb 2020

I should note that I dont understand why these two dropdown buttons are coded differently #27767

avatar Subhang23
Subhang23 - comment - 5 Feb 2020
avatar Quy
Quy - comment - 5 Feb 2020

Issue with RTL language. Install Persian to test.

27816

avatar richard67
richard67 - comment - 5 Feb 2020

@richard67 I have changed it and am sorry for the improper message.

No need to say sorry. I've explained how we normally do it, you followed that, so all is fine.

avatar Subhang23
Subhang23 - comment - 5 Feb 2020

@Quy Is this good?
Screenshot from 2020-02-06 01-33-39

avatar infograf768
infograf768 - comment - 6 Feb 2020

Almost there.
Remains to modify line 383 of /administrator/templates/atum/scss/blocks/_toolbar.scss
from

     @include media-breakpoint-down(sm) {
        [dir=rtl] & {
          margin-left: 0.75rem;
          margin-right: 0 !important;
        }
      }

to

     @include media-breakpoint-down(sm) {
        [dir=rtl] & {
          margin-left: 0.75rem !important;         // Added !important
          margin-right: 0 !important;
        }
      }

before this modification, we get

marginleft_saveandclose

after this modification, we get

marginleft_saveandclose_after

avatar infograf768 infograf768 - test_item - 6 Feb 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 6 Feb 2020

I have tested this item successfully on 50c28d3

Looks OK now to me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27816.

avatar Quy
Quy - comment - 6 Feb 2020

Remove right margin.

27816

avatar infograf768
infograf768 - comment - 6 Feb 2020

@Quy
Not sure we can change that margin, comparing with other views.
In any case, I think it is unrelated to the original reason of this PR.
I suggest to go with what we have here and then see what we can do, if possible, in another PR.

avatar Quy Quy - test_item - 6 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 6 Feb 2020

I have tested this item successfully on 50c28d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27816.

avatar Quy Quy - change - 6 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 6 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27816.

avatar infograf768 infograf768 - change - 6 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-06 18:22:18
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 6 Feb 2020
avatar infograf768 infograf768 - merge - 6 Feb 2020
avatar infograf768
infograf768 - comment - 6 Feb 2020

tks

avatar infograf768 infograf768 - change - 6 Feb 2020
Title
fix error of styling issue with save and close button
[4.0] fix error of styling issue with save and close button
avatar infograf768 infograf768 - edited - 6 Feb 2020
avatar infograf768
infograf768 - comment - 7 Feb 2020

Please test #27841 solving all alignments

Add a Comment

Login with GitHub to post a comment