User tests: Successful: Unsuccessful:
This is a POC and request for feedback
Front end editing is a second class experience in joomla. Depending on your template the available area to edit your content can be very narrow. It is also distracting to have the rest of the site visible when trying to edit the content.
This incredibly simple pull request makes the edit form open full screen with nothing else to distract you.
When you save or cancel the edit you are correctly returned to the previous page.
It's so simple that I am wondering if I missed something obvious
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_content |
@brianteeman thanks for remembering me. I was more concerned about modules possibly appearing above the editing window making it confusing. I wonder if this solved both problems. Happy to test when Inger a few moments.
Labels |
Added:
?
|
Category | Administration com_content | ⇒ | Administration com_content Layout |
Sure, happy to test. Thanks for the contribution there is much we can improve.
"It's so simple that I am wondering if I missed something obvious."
Brian: You are catching along of these things - rightly so. This is/would be an excellent improvement for F/E content editing. Goes right along with my "thing" about Articles being at the bottom of the list - the most used content item type for menu link items, requires a scroll action to get to it vs. having it on top by just naming it with an "A ..." before the name.
You have a sharp eye for this stuff and hope that others will also align with your observations and make the changes you offer.
Title |
|
@brianteeman I can't get patchtester to install, I assume it's possible just to overwrite the files?
Ok I tried overwriting the files but my version of J4 doesn't have them in that location. If you can assist me I will try to test this. Looks like a very simple change so it shouldn't be hard to get it tested.
thats a limitation of using patchtester instead of git when files get moved. The file that has moved is now at administrator\components\com_content\src\Service\HTML\Icon.php
But that directory doesn't exist for me when I use the latest nightly build. Patch tester doesn't install. I tried doing it manually.
then you cannot be using the latest nightly build (or the build is broken) because all the files moves were made 2 days ago
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_content/src/Service/HTML/Icon.php
Labels |
Added:
?
|
Category | Administration com_content Layout | ⇒ | Unit Tests Repository Administration com_admin SQL Postgresql |
Labels |
Added:
?
|
Category | Administration Unit Tests Repository com_admin SQL Postgresql | ⇒ | Administration com_content Layout |
I have updated this PR to use the moved files for you
Ok thanks, I'll just download this Zip and try that
I got it here so maybe worth checking if I'm getting it from the right place or if there's a problem https://developer.joomla.org/nightly-builds.html
@brianteeman sorry to be a pain, I'm really not sure what I'm doing here. Can I just click on "code" and download that Zip or is there something else I need to do?
since i updated the pr then patchtester will work - I just confirmed it on my install
Oh I see. I can't install patch tester though. Hence me looking for the files manually.
JInstaller: :Install: Can't find Joomla XML setup file.
that I have no idea about.
there are just two files to edit with one line in each so in this case you can do it manually
https://github.com/joomla/joomla-cms/pull/27802/files
It looks terrible - its just to see if the concept is ok before spending time on the styling
I have tested this item
I have tested front end editing for modules and for articles. Both show as full screen. As Brian has alluded this is sometimes a little too wide, but the point of this test if that it works. It also solves issue that I previously brought up as it removes all modules. If I can find that issue I will also close it. Good work Brian, I think this is an improvement and my modal version would have been non-accessible.
Thanks for testing it. I will do some more work on it tomorrow so that it doesn't look so ugly and will work with any template.
@brianteeman
Should we test this?
This is a POC and request for feedback
Closed due to lack of interest
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-04 16:32:46 |
Closed_By | ⇒ | brianteeman | |
Labels |
Removed:
?
|
That's a shame I thought it was a valid improvement
@uglyeoin You were asking for something like this before I think