? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Feb 2020

This is a POC and request for feedback

Introduction

Front end editing is a second class experience in joomla. Depending on your template the available area to edit your content can be very narrow. It is also distracting to have the rest of the site visible when trying to edit the content.

This incredibly simple pull request makes the edit form open full screen with nothing else to distract you.

When you save or cancel the edit you are correctly returned to the previous page.

It's so simple that I am wondering if I missed something obvious

Demo video before this PR

after

Demo video with this PR

after

avatar brianteeman brianteeman - open - 4 Feb 2020
avatar brianteeman brianteeman - change - 4 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Feb 2020
Category Administration com_content
avatar brianteeman
brianteeman - comment - 4 Feb 2020

@uglyeoin You were asking for something like this before I think

avatar uglyeoin
uglyeoin - comment - 4 Feb 2020

@brianteeman thanks for remembering me. I was more concerned about modules possibly appearing above the editing window making it confusing. I wonder if this solved both problems. Happy to test when Inger a few moments.

avatar brianteeman
brianteeman - comment - 4 Feb 2020

@uglyeoin as it is right now it wont but the same concept can easily be applied there

avatar brianteeman brianteeman - change - 4 Feb 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 4 Feb 2020
Category Administration com_content Administration com_content Layout
avatar brianteeman
brianteeman - comment - 4 Feb 2020

@uglyeoin you can now test this for modules as well. - looks ugly but this is still just a draft for review

avatar uglyeoin
uglyeoin - comment - 4 Feb 2020

Sure, happy to test. Thanks for the contribution there is much we can improve.

avatar 200MPHMEDIA
200MPHMEDIA - comment - 10 Feb 2020

"It's so simple that I am wondering if I missed something obvious."

Brian: You are catching along of these things - rightly so. This is/would be an excellent improvement for F/E content editing. Goes right along with my "thing" about Articles being at the bottom of the list - the most used content item type for menu link items, requires a scroll action to get to it vs. having it on top by just naming it with an "A ..." before the name.

You have a sharp eye for this stuff and hope that others will also align with your observations and make the changes you offer.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27802.

avatar Quy Quy - change - 10 Feb 2020
Title
[4.0] Full Screen Content edit [rfc]
[RFC][4.0] Full Screen Content edit
avatar Quy Quy - edited - 10 Feb 2020
avatar Quy
Quy - comment - 10 Feb 2020

It will fix this issue #26944

avatar brianteeman
brianteeman - comment - 10 Feb 2020

@Quy only as a side effect and not as intended behaviour

avatar brianteeman
brianteeman - comment - 13 Feb 2020

@uglyeoin I thought you might have found the time to check this out by now - please

avatar uglyeoin
uglyeoin - comment - 15 Feb 2020

@brianteeman I can't get patchtester to install, I assume it's possible just to overwrite the files?

avatar uglyeoin
uglyeoin - comment - 15 Feb 2020

Ok I tried overwriting the files but my version of J4 doesn't have them in that location. If you can assist me I will try to test this. Looks like a very simple change so it shouldn't be hard to get it tested.

avatar brianteeman
brianteeman - comment - 15 Feb 2020

thats a limitation of using patchtester instead of git when files get moved. The file that has moved is now at administrator\components\com_content\src\Service\HTML\Icon.php

avatar uglyeoin
uglyeoin - comment - 15 Feb 2020

But that directory doesn't exist for me when I use the latest nightly build. Patch tester doesn't install. I tried doing it manually.

avatar brianteeman
brianteeman - comment - 15 Feb 2020

then you cannot be using the latest nightly build (or the build is broken) because all the files moves were made 2 days ago
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_content/src/Service/HTML/Icon.php

avatar brianteeman brianteeman - change - 15 Feb 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 Feb 2020
Category Administration com_content Layout Unit Tests Repository Administration com_admin SQL Postgresql
avatar brianteeman brianteeman - change - 15 Feb 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 Feb 2020
Category Administration Unit Tests Repository com_admin SQL Postgresql Administration com_content Layout
avatar brianteeman
brianteeman - comment - 15 Feb 2020

I have updated this PR to use the moved files for you

avatar uglyeoin
uglyeoin - comment - 15 Feb 2020

Ok thanks, I'll just download this Zip and try that

avatar uglyeoin
uglyeoin - comment - 15 Feb 2020

I got it here so maybe worth checking if I'm getting it from the right place or if there's a problem https://developer.joomla.org/nightly-builds.html

avatar uglyeoin
uglyeoin - comment - 15 Feb 2020

@brianteeman sorry to be a pain, I'm really not sure what I'm doing here. Can I just click on "code" and download that Zip or is there something else I need to do?

avatar brianteeman
brianteeman - comment - 15 Feb 2020

since i updated the pr then patchtester will work - I just confirmed it on my install

avatar uglyeoin
uglyeoin - comment - 15 Feb 2020

Oh I see. I can't install patch tester though. Hence me looking for the files manually.

JInstaller: :Install: Can't find Joomla XML setup file.

avatar brianteeman
brianteeman - comment - 15 Feb 2020

that I have no idea about.
there are just two files to edit with one line in each so in this case you can do it manually
https://github.com/joomla/joomla-cms/pull/27802/files

It looks terrible - its just to see if the concept is ok before spending time on the styling

avatar uglyeoin uglyeoin - test_item - 15 Feb 2020 - Tested successfully
avatar uglyeoin
uglyeoin - comment - 15 Feb 2020

I have tested this item successfully on 954ccd2

I have tested front end editing for modules and for articles. Both show as full screen. As Brian has alluded this is sometimes a little too wide, but the point of this test if that it works. It also solves issue that I previously brought up as it removes all modules. If I can find that issue I will also close it. Good work Brian, I think this is an improvement and my modal version would have been non-accessible.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27802.

avatar uglyeoin uglyeoin - test_item - 15 Feb 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 15 Feb 2020

Thanks for testing it. I will do some more work on it tomorrow so that it doesn't look so ugly and will work with any template.

avatar astridx
astridx - comment - 16 Mar 2020

@brianteeman
Should we test this?

avatar brianteeman
brianteeman - comment - 16 Mar 2020

This is a POC and request for feedback

avatar brianteeman
brianteeman - comment - 4 Apr 2020

Closed due to lack of interest

avatar brianteeman brianteeman - close - 4 Apr 2020
avatar brianteeman brianteeman - change - 4 Apr 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-04-04 16:32:46
Closed_By brianteeman
Labels Removed: ?
avatar uglyeoin
uglyeoin - comment - 4 Apr 2020

That's a shame I thought it was a valid improvement

Add a Comment

Login with GitHub to post a comment