? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
4 Feb 2020

Summary of Changes

1_ Fix the menutype for presets menu items.
As the menutype is not saved yet when installing a preset and if the menu type Unique Name created contains spaces, the menutype assigned to the presets menu items is wrong.
To correct this error, the patch already passes it throughstringURLSafe.

2_ Fix installing presets menu items containing unicode aliases when unicode slugs is not set.
This happens when some menu items have been created with unicode slugs and unicode slugs is not set any more in Global Config. As done in the sample data plugins this PR temporarily set unicodeslugs ON if not done yet in Global Config.

Testing Instructions

  1. This test does not need multilingual.
    Just install the Blog sample data in English.
    Go to administrator/index.php?option=com_menus&view=menus and Filter by Administrator.
    Create a new administrator menu.
    Title: Custom admin menu title
    Unique Name: My custom menu // IMPORTANT: must contain spaces!
    Import a Preset: choose Preset - Joomla Main Menu OR Preset - Alternative Main Menu
    Save and close

Then switch to the menu items for this menu type administrator/index.php?option=com_menus&view=items&menutype=
Select the menutype you just created.
The menu items are not displayed.
They are displayed if you do not filter by this menu type i.e. if you let the filter to - Select Menu -

In PHPMyadmin, look at the menu table.
All the new menu items (Easy to find as their titles are lang constants) have My custom menu as menutype.
Look at the menutypes table: the new menutype is correctly my-custom-menu

After patching, this will be solved and items will show and displayed in the menu position by the specific module created for this Menu.

  1. This test needs to install a multilingual site with at least Persian language installed.
    Set Unicode Slugs to No in Global Configuration.
    Install Multilingual sample Data. Some menu items for Persian will contain unicode Persian characters in their aliases.

Now create a new Menu as explained in **1. ** and save.
It will throw an error (Screenshot below the menu type I had created was Myadminmenu)

Screen Shot 2020-02-02 at 07 46 34

Delete the menu.

patch:
all will be fine.

avatar infograf768 infograf768 - open - 4 Feb 2020
avatar infograf768 infograf768 - change - 4 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Feb 2020
Category Administration com_menus
avatar drmenzelit drmenzelit - test_item - 4 Feb 2020 - Tested successfully
avatar drmenzelit
drmenzelit - comment - 4 Feb 2020

I have tested this item successfully on a8190fc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27800.

avatar chmst chmst - test_item - 4 Feb 2020 - Tested successfully
avatar chmst
chmst - comment - 4 Feb 2020

I have tested this item successfully on a8190fc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27800.

avatar Quy Quy - change - 4 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 4 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27800.

avatar infograf768
infograf768 - comment - 4 Feb 2020

rtc
Thanks for testing!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27800.

avatar wilsonge wilsonge - change - 4 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-04 20:59:31
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 4 Feb 2020
avatar wilsonge wilsonge - merge - 4 Feb 2020
avatar wilsonge
wilsonge - comment - 4 Feb 2020

Thanks JM!

Add a Comment

Login with GitHub to post a comment