User tests: Successful: Unsuccessful:
1_ Fix the menutype for presets menu items.
As the menutype is not saved yet when installing a preset and if the menu type Unique Name
created contains spaces, the menutype assigned to the presets menu items is wrong.
To correct this error, the patch already passes it throughstringURLSafe
.
2_ Fix installing presets menu items containing unicode aliases when unicode slugs is not set.
This happens when some menu items have been created with unicode slugs and unicode slugs is not set any more in Global Config. As done in the sample data plugins this PR temporarily set unicodeslugs ON if not done yet in Global Config.
administrator/index.php?option=com_menus&view=menus
and Filter by Administrator.Preset - Joomla Main Menu
OR Preset - Alternative Main Menu
Then switch to the menu items for this menu type administrator/index.php?option=com_menus&view=items&menutype=
Select the menutype you just created.
The menu items are not displayed.
They are displayed if you do not filter by this menu type i.e. if you let the filter to - Select Menu -
In PHPMyadmin, look at the menu table.
All the new menu items (Easy to find as their titles are lang constants) have My custom menu
as menutype.
Look at the menutypes table: the new menutype is correctly my-custom-menu
After patching, this will be solved and items will show and displayed in the menu position by the specific module created for this Menu.
Now create a new Menu as explained in **1. ** and save.
It will throw an error (Screenshot below the menu type I had created was Myadminmenu
)
Delete the menu.
patch:
all will be fine.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_menus |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
rtc
Thanks for testing!
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-04 20:59:31 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks JM!
I have tested this item✅ successfully on a8190fc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27800.